Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check fonts in inline translation view #2459

Closed
ahmedre opened this issue Nov 12, 2023 · 2 comments · Fixed by #2467
Closed

Check fonts in inline translation view #2459

ahmedre opened this issue Nov 12, 2023 · 2 comments · Fixed by #2467

Comments

@ahmedre
Copy link
Contributor

ahmedre commented Nov 12, 2023

Some Arabic text is broken on older devices.
@ahmedre
Copy link
Contributor Author

ahmedre commented Nov 12, 2023

ex from Jalalayn sura Ma'ida ayah 60, and other examples in ayah 2, etc.
tempFileForShare_20230328-064618

@ahmedre
Copy link
Contributor Author

ahmedre commented Nov 12, 2023

@mustafa0x suggested using Kitab font here too should solve this in sha' Allah.

@ahmedre ahmedre mentioned this issue Nov 17, 2023
Merged
ahmedre added a commit that referenced this issue Nov 17, 2023
@ahmedre
Use Kitab font for inline Arabic translation
79fd87a 
This uses the Kitab font for the inline ayah translation view, just like
the full screen translation view does. This helps fix artifacts and
strange issues on older phones with how some characters are rendered.
Also made the Arabic text slightly larger in this view. Fixes #2459.
@ahmedre ahmedre mentioned this issue Jan 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use Kitab font for inline Arabic translation quran/quran_android
1 participant
@ahmedre