Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Kitab font for inline Arabic translation #2467

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Conversation

ahmedre
Copy link
Contributor

@ahmedre ahmedre commented Nov 17, 2023

This uses the Kitab font for the inline ayah translation view, just like
the full screen translation view does. This helps fix artifacts and
strange issues on older phones with how some characters are rendered.
Also made the Arabic text slightly larger in this view. Fixes #2459.

This uses the Kitab font for the inline ayah translation view, just like
the full screen translation view does. This helps fix artifacts and
strange issues on older phones with how some characters are rendered.
Also made the Arabic text slightly larger in this view. Fixes #2459.
Copy link

OLD: app-madani-debug.apk (signature: V1, V2)
NEW: app-madani-debug.apk (signature: V1, V2)

          │           compressed           │           uncompressed           
          ├───────────┬───────────┬────────┼───────────┬───────────┬──────────
 APK      │ old       │ new       │ diff   │ old       │ new       │ diff     
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼──────────
      dex │  12.5 MiB │  12.5 MiB │ +644 B │  31.9 MiB │  31.9 MiB │ +1.6 KiB 
     arsc │   2.2 MiB │   2.2 MiB │    0 B │   2.2 MiB │   2.2 MiB │      0 B 
 manifest │   5.6 KiB │   5.6 KiB │    0 B │  27.1 KiB │  27.1 KiB │      0 B 
      res │   1.6 MiB │   1.6 MiB │    0 B │   1.8 MiB │   1.8 MiB │      0 B 
    asset │ 404.2 KiB │ 404.2 KiB │    0 B │ 678.6 KiB │ 678.6 KiB │      0 B 
    other │   188 KiB │   188 KiB │  +15 B │ 384.5 KiB │ 384.5 KiB │      0 B 
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼──────────
    total │  16.9 MiB │  16.9 MiB │ +659 B │  36.9 MiB │  36.9 MiB │ +1.6 KiB 


@ahmedre ahmedre merged commit 3de4b72 into master Nov 17, 2023
4 checks passed
@ahmedre ahmedre deleted the inline_arabic_font branch November 17, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check fonts in inline translation view
1 participant