Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remember selection to see translations #530

Closed
ahmedre opened this issue May 26, 2015 · 4 comments
Closed

remember selection to see translations #530

ahmedre opened this issue May 26, 2015 · 4 comments
Labels
PRs Welcome

Comments

@ahmedre
Copy link
Contributor

ahmedre commented May 26, 2015

when a user goes into translations, we should probably default them to translations by default.
@ozbek
Copy link
Contributor

ozbek commented May 27, 2015

Do you mean the case when there are no already downloaded translations?

@ahmedre
Copy link
Contributor Author

ahmedre commented May 27, 2015

no - as in when you choose a sura and tap the globe to open translation mode, when you hit back, we take you to the index. so next time you tap a page (or the "last page" button), let's go back to translation by default instead of to the arabic page.

@ozbek
Copy link
Contributor

ozbek commented May 27, 2015

I see. I have never used the back button at the top. Now that I tried, I see an inconsistency with the system back button:

  • Pressing the back button at the top opens the index page.
  • Pressing the system back button opens the Arabic page.

So, then pressing the system back button should also open the index page.

@ahmedre
Copy link
Contributor Author

ahmedre commented Nov 23, 2016

anyone should feel free to work on this and send a PR

@ozbek ozbek mentioned this issue Dec 13, 2016
Merged
ahmedre pushed a commit that referenced this issue Dec 15, 2016
@ozbek @ahmedre
Remember the last reading mode (#736)
9dafc94 
This will enable going back to translation mode
when jump to last page is selected from the action bar.

Fix #530.
ahmedre pushed a commit that referenced this issue Oct 14, 2017
@ozbek @ahmedre
Remember the last reading mode (#736)
acbbfad 
This will enable going back to translation mode
when jump to last page is selected from the action bar.

Fix #530.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
PRs Welcome
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ahmedre @ozbek