Remember the last reading mode #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will enable going back to translation mode when jump to last page is selected from the action bar. Fix #530.
|
Please don't merge yet. This has side effect on recent pages. |
|
what is the side effect on recent pages? it might be my bug if so, because otherwise, this seems right (code wise anyway). |
Once the mode is changed to translation, all entries go to translation mode (from sura list, bookmarks, etc) except from "Jump to" menu (this always opens in Quran mode). I think, I need more details on the "concept" of #530. Should we open the page in previous mode only from "Last page" menu? Or always? |
|
i am ok either way (i can see the argument for both). |
|
if so, please go ahead and merge :) |
|
jazakAllah khairan |
ahmedre
pushed a commit
that referenced
this pull request
Oct 14, 2017
This will enable going back to translation mode when jump to last page is selected from the action bar. Fix #530.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will enable going back to translation mode when jump to last page is selected from the action bar.
Fix #530.