Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade travis orientdb version to 2.0.11 #20

Merged
merged 2 commits into from
Aug 22, 2015
Merged

Downgrade travis orientdb version to 2.0.11 #20

merged 2 commits into from
Aug 22, 2015

Conversation

ernestas-poskus
Copy link
Contributor

Testing with Travis with orientdb 2.0.11

@ernestas-poskus
Copy link
Contributor Author

func NewDBClient(opts ClientOptions) (*DBClient, error) {
.....
// after connecting the OrientDB server sends back 2 bytes - its binary protocol version
readbuf := make([]byte, 2)
n, err := conx.Read(readbuf)
if err != nil {
    return nil, oerror.NewTrace(err)
}

n, err := conx.Read(readbuf)

n returns 0 for some reason, maybe orientdb setup is bad will test with extra bash script

@ernestas-poskus
Copy link
Contributor Author

@quux00 hey good news, travis is fixed problem was with binary configuration

n returns 0 for some reason, maybe orientdb setup is bad will test with extra bash script

☝️ that is connection error and it should have happen sooner for example when initialising connection to driver.

@quux00 quux00 merged commit 1fb203f into istreamdata:master Aug 22, 2015
@ernestas-poskus ernestas-poskus deleted the features/downgrade_travis_orientdb_version branch August 22, 2015 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants