More vim movements for filebrowser #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 'gg' goes to top * 'G' goes to bottom
* '^e' moves up one line * '^e' moves down one line
* '^f' scrolls down one screen * '^f' scrolls up one screen
| if (modifierFlags & NSControlKeyMask) { | ||
| [self.actionDelegate actionScrollUpOneScreen]; | ||
| } | ||
| return YES; |
There was a problem hiding this comment.
For 'e', 'y', 'f', and 'b' YES is returned even if the control key isn't pressed. I think return YES should be moved into the if statements and NO should be returned otherwise.
There was a problem hiding this comment.
The meaning of the return value of processKeyModeNormal was not entirely clear to me. It returns YES when the key command is known, NO otherwise, right?
If that's the case then I absolutely agree with you.
|
You are very welcome. I'll add the tests when I've time for it, probably later today or tomorrow. |
|
I added unit tests for the new vim key movements. Okay like that? |
qvacua
pushed a commit
that referenced
this pull request
Sep 6, 2015
More vim movements for filebrowser
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enables new vim-like movements to the file browser:
ggandGthat jump to the top and the bottom of the file browser