Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"streak" is wrong on midair mode #260

Closed
mushis opened this issue Oct 8, 2022 · 5 comments
Closed

"streak" is wrong on midair mode #260

mushis opened this issue Oct 8, 2022 · 5 comments

Comments

@mushis
Copy link
Contributor

mushis commented Oct 8, 2022

It seems that the endstat "Streak" is calculated incorrectly on midair game mode.

image

ktx 1.42 dev

@tcsabina
Copy link
Collaborator

tcsabina commented Oct 8, 2022

Hey mushi!
From the screenshot it is not obvious that it is wrong ;).
So you died between the 26 kills, you say?

I took a quick peek on the code. The midair stat is using the same variable as the normal game. So if this is wrong in midair, it will be wrong in a normal game mode as well.

Anyhow, I will do some testing with a bot...

@tcsabina
Copy link
Collaborator

tcsabina commented Oct 8, 2022

Mushi,
I did a quick match with a bot, and with 2 clients of my own. It looks okay to me.

@mushis
Copy link
Contributor Author

mushis commented Oct 9, 2022

so, I killed the enemy 26 times in total.
he killed me 4.
how can I have a 26 streak?

edit: looking more carefully, on the second table there is a column called Strk. 11 sounds reasonable.

@tcsabina
Copy link
Collaborator

Hi mushi,

I have finally found the bug. It was in the original endgame stats, not introduced with the new one. Fixed anyhow..

Thanks for reporting!

@tcsabina
Copy link
Collaborator

PR #264 takes care of this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants