Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commands Outside of Repo Have Unexpected Results #31

Closed
niedzielski opened this issue Mar 14, 2015 · 2 comments
Closed

Commands Outside of Repo Have Unexpected Results #31

niedzielski opened this issue Mar 14, 2015 · 2 comments

Comments

@niedzielski
Copy link

Running gg s outside of a Git repo produces a stacktrace:

/usr/local/lib/node_modules/gitgoodies/lib/gg.js:164
                switch (status[1].split(' ')[3]) {
                                 ^
TypeError: Cannot read property 'split' of undefined
    at /usr/local/lib/node_modules/gitgoodies/lib/gg.js:164:20
    at ChildProcess.exithandler (child_process.js:751:5)
    at ChildProcess.emit (events.js:110:17)
    at maybeClose (child_process.js:1008:16)
    at Socket.<anonymous> (child_process.js:1176:11)
    at Socket.emit (events.js:107:17)
    at Pipe.close (net.js:476:12)

Similarly, gg a outside of a repo makes a false claim:

[✔] Added everything!
@qw3rtman
Copy link
Owner

Thanks for the info. I believe @Jackamo had begun work on checking if we were in a Git repository prior to running any commands.

@qw3rtman
Copy link
Owner

Fixed by #44. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants