Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer money GUI #4

Closed
speqtr opened this issue Nov 3, 2019 · 13 comments
Closed

Transfer money GUI #4

speqtr opened this issue Nov 3, 2019 · 13 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@speqtr
Copy link
Contributor

speqtr commented Nov 3, 2019

Objective:

Users should be able to create a transaction by manually adding transaction data (recipient address, transfer amount, comment, etc).

Solution:

Develop Transfer money page:

  • open Transfer money page;
  • input recipient address, amount;
  • (optional) input transaction ID;
  • hit Send button;
  • app validates transaction data and sends it to the QWC network.

Value (for developers, product and/or users):

Users will be able to transfer money by manually typing data.

DoD (Definition of Done):

Users are able to create transactions by manually typing data.

@speqtr speqtr added the enhancement New feature or request label Nov 3, 2019
@speqtr speqtr added this to the QWCX v1.0.0 milestone Nov 3, 2019
@speqtr speqtr self-assigned this Nov 3, 2019
@speqtr
Copy link
Contributor Author

speqtr commented Nov 3, 2019

Preview:
IMAGE001
PS: I think it is really convenient to see total balance while creating a new transaction. It helps to be sure that there are enough funds before hitting Send button.

@speqtr
Copy link
Contributor Author

speqtr commented Nov 3, 2019

ping @exploshot, @nnian, @Xecute0101 🙂

@exploshot
Copy link
Member

exploshot commented Nov 3, 2019

Is there a recheck (do you wanna really send 200Bn QWC to QWCasd...as?) available like in the actual mobile wallet from me, or the GUI/Zero Wallet?

@speqtr
Copy link
Contributor Author

speqtr commented Nov 3, 2019

Is there a recheck (do you wanna really send 200Bn QWC to QWCasd...as?) available like in the actual mobile wallet from me, or the GUI/Zero Wallet?

Yes, sure. There is a warning at the bottom and a big popup dialog that asks for confirmation after pressing Send button.

And in one of the future versions there will be a small popup at the bottom of the screen with text like Sending 0.01 QWC to QWCabc...z and Undo button. So there will be extra 5 seconds for users if they want to cancel the transaction after confirming the Send action in dialog (like in GUI/Zero wallet).

@Xecute0101
Copy link

One of the issues that all current wallets have is that the total transaction amount is not correctly displayed like tx fees and developer donations into final balance. Like if I want to send 1,000,000 QWC, the total balance for this transaction will be 1,000,000 + all fees when confirming txs.

@Xecute0101
Copy link

Using a built-in finger print authorization or face id on iOS would be perfect. Undo Pop-up with delay will be great like when you exit any telegram accounts.

@speqtr
Copy link
Contributor Author

speqtr commented Nov 7, 2019

One of the issues that all current wallets have is that the total transaction amount is not correctly displayed like tx fees and developer donations into final balance. Like if I want to send 1,000,000 QWC, the total balance for this transaction will be 1,000,000 + all fees when confirming txs.

I agree. "Final amount" is something really important from user perspective. I will think on an interface adjustments for showing it on Transfer money page.

@speqtr
Copy link
Contributor Author

speqtr commented Nov 7, 2019

Using a built-in finger print authorization or face id on iOS would be perfect.

I have it on my TODO list. I think we can add this feature as a "patch release" after v1.0 is out.

@speqtr
Copy link
Contributor Author

speqtr commented Nov 7, 2019

Undo Pop-up with delay will be great like when you exit any telegram accounts.

True. It is really convenient 👍

@nnian
Copy link
Member

nnian commented Nov 10, 2019

Can I, as a user, only send QWC, for example 5Mio QWC to @speqtr , or can I also send $ 20 to @Xecute0101 and the amount will be converted into QWC?

@speqtr
Copy link
Contributor Author

speqtr commented Nov 11, 2019

@nnian in the first version only QWC amount can be entered and approximate amount in USD (or other fiat currency) will be shown as a read-only information (under QWC amount).

After we properly test QWC<-->fiat rates in "read-only" format then (in one of the next versions) we will enable a new feature that will allow users to set transaction amount in almost any currency and automatically convert it to QWC.

@nnian
Copy link
Member

nnian commented Nov 11, 2019

After we properly test QWC<-->fiat rates in "read-only" format [...] convert it to QWC.

Sounds great. I'm fine with that.

@speqtr
Copy link
Contributor Author

speqtr commented Dec 4, 2019

All feedback was taken into an account and updated GUI is already implemented. Further requests can be sent to #1 or by opening a separate issue on GitHub.

@speqtr speqtr closed this as completed Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants