Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uninformative addmodule / addcmodule error #13

Open
qwoprocks opened this issue Nov 13, 2020 · 1 comment
Open

Uninformative addmodule / addcmodule error #13

qwoprocks opened this issue Nov 13, 2020 · 1 comment

Comments

@qwoprocks
Copy link
Owner

qwoprocks commented Nov 13, 2020

Refer to ss below. The module name only contains alphanumeric characters, yet it is rejected because of the small letter 's'. Changing it to uppercase causes the command to pass. The error message should be changed to reflect this constraint.

image.png

@nus-pe-bot
Copy link

nus-pe-bot commented Nov 18, 2020

Team's Response

Thank you for raising this issue with us. As mentioned in the UG, the module name to be input should follow the valid module code formatting.

image.png

Items for the Tester to Verify

❓ Issue response

Team chose [response.Rejected]

  • I disagree

Reason for disagreement: I feel that this is a cosmetic issue. By having error messages with not enough detail, may be confusing for some users, and slightly defeats the purpose of having the error message in the first place.


❓ Issue type

Team chose [type.FunctionalityBug]
Originally [type.DocumentationBug]

  • I disagree

Reason for disagreement: [replace this with your explanation]


❓ Issue severity

Team chose [severity.Low]
Originally [severity.VeryLow]

  • I disagree

Reason for disagreement: Again, I feel that this is more of a cosmetic issue that will not affect normal operations of the product, especially since first time users will likely be reading the User Guide while familiarising themselves with the application. Thus, I feel that this belongs more to the VeryLow catergory rather than the Low category.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants