Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] 版权声明被错误移除 / Original copyright details removed wrongly #219

Closed
Young-Lord opened this issue Mar 11, 2024 · 5 comments
Labels
Bug Something isn't working

Comments

@Young-Lord
Copy link

Young-Lord commented Mar 11, 2024

2ce3cea 中,TMessagesProj/src/main/java/org/telegram/messenger/BuildVars.java头部的 GPL v2 版权声明 Copyright Nikolai Kudashov, 2013-2020. 被错误移除,并替换为 Copyright (C) 2019-2024 qwq233 <qwq233@qwq2333.top>
虽然您对此文件有更改,但显然更正确的做法是保留此行版权声明,而且我看你在TMessagesProj/src/目录下的其他文件也都是保留了原有版权声明的。

P.S. CONTRIBUTING.md里这个code header是指什么,版权声明吗?我个人认为具体写清楚会比较好
P.P.S. Compilation Guide太旧了,而且有些不清楚(比如说那个two android apps with application IDs),感觉可以直接删了换成指向上游的超链接

@Young-Lord Young-Lord added the Bug Something isn't working label Mar 11, 2024
@qwq233
Copy link
Owner

qwq233 commented Mar 12, 2024

@Young-Lord 1. as自动改的 我看看能不能调成保留 不能就不强求了 已经改了的就不改回去了太麻烦
2. 是 理论上as会自动加创建新文件 我加这条是怕有人删了
3. 构筑建议参考ci 文档我极少更新

@Young-Lord
Copy link
Author

关于3,构建我是能跑起来的,但是由于 ba8cec7 引入的签名校验 以及一些别的东西(不确定是 Firebase 还是 tg API_HASH),我觉得别人按照 ci 跑也不容易跑起来

@qwq233
Copy link
Owner

qwq233 commented Mar 12, 2024

关于3,构建我是能跑起来的,但是由于 ba8cec7 引入的签名校验 以及一些别的东西(不确定是 Firebase 还是 tg API_HASH),我觉得别人按照 ci 跑也不容易跑起来

你提及的都不影响构筑,构筑只需要替换签名这些
或者你用debug签名都可以,可以参考pr的ci

@Young-Lord
Copy link
Author

只是编译的话确实可以正常编译,但打开后 退出/白屏 对开发者来说还是会比较怪
(貌似有点 offtopic 了?)

@qwq233
Copy link
Owner

qwq233 commented Mar 31, 2024

更新了部分文档,copyright不清楚怎么规范作用域,暂不处理了

@qwq233 qwq233 closed this as not planned Won't fix, can't repro, duplicate, stale Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants