Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accommodate for blank Mac, IP #5

Closed
tresf opened this issue Dec 20, 2016 · 2 comments
Closed

Accommodate for blank Mac, IP #5

tresf opened this issue Dec 20, 2016 · 2 comments
Labels
bug

Comments

@tresf
Copy link
Contributor

tresf commented Dec 20, 2016 •
edited
Loading

After further testing, some Network adapters are missing a Mac address. Since Java's not sending this information over, it's failing the toss logic.

Adding fallback to ip suffers the same bug.... Adapters without an IP will fail to sift.

Here's a proposal to fix this #4.... I'm not sure this is the right design. Perhaps a better design is to send across at least one null Mac address?
@tresf
Copy link
Contributor Author

tresf commented Dec 20, 2016 •
edited
Loading

@bberenz there's a second bug to this problem... the blank mac is also incorrectly flagging adapters without a Mac Address at all as physical due to (I believe) this line: https://github.com/qzind/sift/blob/master/sift.js#L47

@tresf
Copy link
Contributor Author

tresf commented Jan 20, 2017

Closed via 89e8598.

@tresf tresf closed this as completed Jan 20, 2017
@tresf tresf added the bug label Jan 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tresf