Deprecate dbListResults() #58
Comments
|
Yes, should be deprecated. |
|
How to go about closing all open result sets if setMethod("onPassivate", "DBIConnection", function(object) {
rs <- dbListResults(object)
lapply(rs, function(x) {
if (dbIsValid(x)) {
dbClearResult(x)
dbRollback(object)
}
})
}) |
|
You need to maintain your own list if that's important - there's no guarantee that that code would work correctly today. |
|
@jcheng5 -- should we change this now? Or are we happy with using this method for the first release? It seems to work fine for RSQLite and MySQL, at least. |
|
@hadley It's hard for us to maintain a list because we hand out connections with What specifically about Barbara's code won't work correctly today? We know there's the problem with SQLite but |
|
@jcheng5 I don't think in general you should assume that |
|
Just for future reference: the deprecation of |
|
DBItest will test that an open result set is closed (with a warning) when the connection is closed. Also, I'm fine with restricting the number of simultaneously open result sets to 1 for now; implementing dbListResults() seems trivial in this scenario, so that it doesn't need to be deprecated. Would that help? |
|
@krlmlr: As far as |
- The `SQL()` function gains a `names` argument which can be used to assign names to SQL strings. - `dbListResults()` is deprecated by documentation (#58). - `dbGetException()` is soft-deprecated by documentation (#51). - Help pages for generics now contain a dynamic list of methods implemented by DBI backends (#162). - `sqlInterpolate()` now supports both named and positional variables (#216, @hannesmuehleisen). - Specialized methods for `dbQuoteString()` and `dbQuoteIdentifier()` are available again, for compatibility with clients that use `getMethod()` to access them (#218).
…ps the names from the output if the `names` argument is unset. - The `dbReadTable()`, `dbWriteTable()`, `dbExistsTable()`, `dbRemoveTable()`, and `dbListFields()` generics now specialize over the first two arguments to support implementations with the `Id` S4 class as type for the second argument. Some packages may need to update their documentation to satisfy R CMD check again. New generics ------------ - Schema support: Export `Id()`, new generics `dbListObjects()` and `dbUnquoteIdentifier()`, methods for `Id` that call `dbQuoteIdentifier()` and then forward (#220). - New `dbQuoteLiteral()` generic. The default implementation uses switchpatch to avoid dispatch ambiguities, and forwards to `dbQuoteString()` for character vectors. Backends may override methods that also dispatch on the second argument, but in this case also an override for the `"SQL"` class is necessary (#172). Default implementations ----------------------- - Default implementations of `dbQuoteIdentifier()` and `dbQuoteLiteral()` preserve names, default implementation of `dbQuoteString()` strips names (#173). - Specialized methods for `dbQuoteString()` and `dbQuoteIdentifier()` are available again, for compatibility with clients that use `getMethod()` to access them (#218). - Add default implementation of `dbListFields()`. - The default implementation of `dbReadTable()` now has `row.names = FALSE` as default and also supports `row.names = NULL` (#186). API changes ----------- - The `SQL()` function gains an optional `names` argument which can be used to assign names to SQL strings. Deprecated generics ------------------- - `dbListConnections()` is soft-deprecated by documentation. - `dbListResults()` is deprecated by documentation (#58). - `dbGetException()` is soft-deprecated by documentation (#51). - The deprecated `print.list.pairs()` has been removed. Bug fixes --------- - Fix `dbDataType()` for `AsIs` object (#198, @yutannihilation). - Fix `dbQuoteString()` and `dbQuoteIdentifier()` to ignore invalid UTF-8 strings (r-dbi/DBItest#156). Documentation ------------- - Help pages for generics now contain a dynamic list of methods implemented by DBI backends (#162). - `sqlInterpolate()` now supports both named and positional variables (#216, @hannesmuehleisen). - Point to db.rstudio.com (@wibeasley, #209). - Reflect new 'r-dbi' organization in `DESCRIPTION` (@wibeasley, #207). Internal -------- - Using switchpatch on the second argument for default implementations of `dbQuoteString()` and `dbQuoteIdentifier()`.
Seems to be unsupported by existing backends, sometimes only one active result set is supported. Deprecate?
The text was updated successfully, but these errors were encountered: