Deprecate dbGetException #51
Labels
Projects
Comments
This was referenced Feb 8, 2016
krlmlr
pushed a commit
to r-dbi/DBItest
that referenced
this issue
Feb 8, 2016
krlmlr
pushed a commit
to r-dbi/DBItest
that referenced
this issue
Feb 8, 2016
- Fix broken tests for quoting. - Call `dbRemoveTable()` instead of issuing `DROP` requests, the latter might be unsupported. - Use subqueries in queries that use `WHERE`. - Remove test for `dbGetException()` (r-dbi/DBI#51). - New tweak `strict_identifier`, if `TRUE` all identifier must be syntactic names even if quoted. The quoting test is now split, and a part is ignored conditional to this tweak.
krlmlr
pushed a commit
to r-dbi/DBItest
that referenced
this issue
Feb 12, 2016
- New feature: tweaks
- New argument `tweaks` to `make_context()` (#49).
- New `tweaks()`, essentially constructs a named list of tweaks but with predefined and documented argument names.
- `constructor_name`, respected by the `constructor.*` tests.
- `strict_identifier`, if `TRUE` all identifier must be syntactic names even if quoted. The quoting test is now split, and a part is ignored conditional to this tweak. The `roundtrip_quotes` tests also respects this tweak.
- `omit_blob_tests` for DBMS that don't have a BLOB data type.
- `current_needs_parens` -- some SQL dialects (e.g., BigQuery) require parentheses for the functions `current_date`, `current_time` and `current_timestamp`.
- `union`, for specifying a nonstandard way of combining queries. All union queries now name each column in each subquery (required for `bigrquery`).
- New tests
- `dbGetInfo(Result)` (r-dbi/DBI#55).
- `dbListFields()` (#26).
- New "package_name" test in `test_getting_started()`.
- Improved tests
- Stress test now installs package in temporary library (before loading `DBI`) using `R CMD INSTALL` before loading DBI (r-dbi/RSQLite#128, #48).
- Row count is now tested for equality but not identity, so that backends can return a numeric value > 2^31 at their discretion.
- Call `dbRemoveTable()` instead of issuing `DROP` requests, the latter might be unsupported.
- Use subqueries in queries that use `WHERE`.
- Test that `dbClearResult()` on a closed result set raises a warning.
- Expect a warning instead of an error for double disconnect (#50).
- Move connection test that requires `dbFetch()` to `test_result()`.
- Split "can_connect_and_disconnect" test.
- Expect `DBI` to be in `Imports`, not in `Depends`.
- Removed tests
- Remove test for `dbGetException()` (r-dbi/DBI#51).
- Bug fixes
- Fix broken tests for quoting.
- Self-testing
- Test `RPostgres`, `RMySQL`, `RSQLite` and `RKazam` as part of the Travis-CI tests (#52).
- Travis CI now installs rstats-db/DBI, updated namespace imports (`dbiCheckCompliance()`, `dbListResults()`).
- Use fork of `testthat`.
- Utilities
- Return test results as named array of logical. Requires r-lib/testthat#360, gracefully degrades with the CRAN version.
- Internal
- Refactored the `get_info_()` tests to use a vector of names.
- Use versioned dependency for DBI
- Use unqualified calls to `dbBind()` again
- Same as 1.0-8.
imanuelcostigan
added a commit
to imanuelcostigan/RSQLServer
that referenced
this issue
Jun 4, 2016
To be deprecated from DBI: r-dbi/DBI#51
|
Deprecation needs to happen at the level of individual drivers first. The way I see it we're going to have "legacy" DBI drivers, and code that uses it, for a long time; no need to make the life of their users harder than necessary. |
krlmlr
added a commit
that referenced
this issue
Jan 27, 2018
- The `SQL()` function gains a `names` argument which can be used to assign names to SQL strings. - `dbListResults()` is deprecated by documentation (#58). - `dbGetException()` is soft-deprecated by documentation (#51). - Help pages for generics now contain a dynamic list of methods implemented by DBI backends (#162). - `sqlInterpolate()` now supports both named and positional variables (#216, @hannesmuehleisen). - Specialized methods for `dbQuoteString()` and `dbQuoteIdentifier()` are available again, for compatibility with clients that use `getMethod()` to access them (#218).
krlmlr
added a commit
that referenced
this issue
Mar 9, 2018
…ps the names from the output if the `names` argument is unset. - The `dbReadTable()`, `dbWriteTable()`, `dbExistsTable()`, `dbRemoveTable()`, and `dbListFields()` generics now specialize over the first two arguments to support implementations with the `Id` S4 class as type for the second argument. Some packages may need to update their documentation to satisfy R CMD check again. New generics ------------ - Schema support: Export `Id()`, new generics `dbListObjects()` and `dbUnquoteIdentifier()`, methods for `Id` that call `dbQuoteIdentifier()` and then forward (#220). - New `dbQuoteLiteral()` generic. The default implementation uses switchpatch to avoid dispatch ambiguities, and forwards to `dbQuoteString()` for character vectors. Backends may override methods that also dispatch on the second argument, but in this case also an override for the `"SQL"` class is necessary (#172). Default implementations ----------------------- - Default implementations of `dbQuoteIdentifier()` and `dbQuoteLiteral()` preserve names, default implementation of `dbQuoteString()` strips names (#173). - Specialized methods for `dbQuoteString()` and `dbQuoteIdentifier()` are available again, for compatibility with clients that use `getMethod()` to access them (#218). - Add default implementation of `dbListFields()`. - The default implementation of `dbReadTable()` now has `row.names = FALSE` as default and also supports `row.names = NULL` (#186). API changes ----------- - The `SQL()` function gains an optional `names` argument which can be used to assign names to SQL strings. Deprecated generics ------------------- - `dbListConnections()` is soft-deprecated by documentation. - `dbListResults()` is deprecated by documentation (#58). - `dbGetException()` is soft-deprecated by documentation (#51). - The deprecated `print.list.pairs()` has been removed. Bug fixes --------- - Fix `dbDataType()` for `AsIs` object (#198, @yutannihilation). - Fix `dbQuoteString()` and `dbQuoteIdentifier()` to ignore invalid UTF-8 strings (r-dbi/DBItest#156). Documentation ------------- - Help pages for generics now contain a dynamic list of methods implemented by DBI backends (#162). - `sqlInterpolate()` now supports both named and positional variables (#216, @hannesmuehleisen). - Point to db.rstudio.com (@wibeasley, #209). - Reflect new 'r-dbi' organization in `DESCRIPTION` (@wibeasley, #207). Internal -------- - Using switchpatch on the second argument for default implementations of `dbQuoteString()` and `dbQuoteIdentifier()`.
28 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
r-dbi/RMySQL#106 (comment)
The text was updated successfully, but these errors were encountered: