New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error handling issues on R-devel #38

Merged
merged 1 commit into from Feb 10, 2018

Conversation

Projects
None yet
2 participants
@gaborcsardi
Copy link
Member

gaborcsardi commented Feb 10, 2018

They are caused by a behavior change in saveRDS.
It always used to create the output file, but now
it does not do that any more, if the object to write
out cannot be successfully created.
See wch/r-source@9245829

Closes #37

Fix error handling issues on R-devel
They are caused by a behavior change in saveRDS.
It always used to create the output file, but now
it does not do that any more, if the object to write
out cannot be successfully created.
See wch/r-source@9245829

Closes #37
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 10, 2018

Codecov Report

Merging #38 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
+ Coverage    76.7%   76.73%   +0.02%     
==========================================
  Files          43       43              
  Lines        2778     2781       +3     
==========================================
+ Hits         2131     2134       +3     
  Misses        647      647
Impacted Files Coverage Δ
R/result.R 96.66% <100%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5869d2...f590be8. Read the comment docs.

@gaborcsardi gaborcsardi merged commit 3dd1dfa into master Feb 10, 2018

6 checks passed

codecov/patch 100% of diff hit (target 76.7%)
Details
codecov/project 76.73% (+0.02%) compared to e5869d2
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment