Merge pull request #1200 from jimhester/feature/protocol

Fully specify host url for install_github.  

Fixes #1131. Closes #1142

NEWS.md

@@ -7,6 +7,8 @@
 
 * `install_dev_deps()` gets everything you need to start development on source
   package - it installs all dependencies, and roxygen2 (#1193).
+* `install_github()` now uses `https://api.github.com` as the host argument, so
+  users can specify 'http:' or other protocols if needed. (@jimhester, #1131, #1200)
 
 * `build_vignette()` will now only install the "VignetteBuilder" if it's 
   not present, not try and upgrade it if it is (#1139).

R/install-github.r

@@ -54,7 +54,7 @@
 install_github <- function(repo, username = NULL,
                            ref = "master", subdir = NULL,
                            auth_token = github_pat(quiet),
-                           host = "api.github.com", quiet = FALSE,
+                           host = "https://api.github.com", quiet = FALSE,
                            ...) {
 
   remotes <- lapply(repo, github_remote, username = username, ref = ref,
@@ -65,7 +65,7 @@ install_github <- function(repo, username = NULL,
 
 github_remote <- function(repo, username = NULL, ref = NULL, subdir = NULL,
                        auth_token = github_pat(), sha = NULL,
-                       host = "api.github.com") {
+                       host = "https://api.github.com") {
 
   meta <- parse_git_repo(repo)
   meta <- github_resolve_ref(meta$ref %||% ref, meta)
@@ -91,7 +91,7 @@ github_remote <- function(repo, username = NULL, ref = NULL, subdir = NULL,
 #' @export
 remote_download.github_remote <- function(x, quiet = FALSE) {
   dest <- tempfile(fileext = paste0(".tar.gz"))
-  src_root <- paste0("https://", x$host, "/repos/", x$username, "/", x$repo)
+  src_root <- paste0(x$host, "/repos/", x$username, "/", x$repo)
   src <- paste0(src_root, "/tarball/", x$ref)
 
   if (!quiet) {
@@ -117,7 +117,7 @@ remote_download.github_remote <- function(x, quiet = FALSE) {
 }
 
 github_has_remotes <- function(x, auth = NULL) {
-  src_root <- paste0("https://", x$host, "/repos/", x$username, "/", x$repo)
+  src_root <- paste0(x$host, "/repos/", x$username, "/", x$repo)
   src_submodules <- paste0(src_root, "/contents/.gitmodules?ref=", x$ref)
   response <- httr::HEAD(src_submodules, , auth)
   identical(httr::status_code(response), 200L)