Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helper to manage Remotes #1304

Closed
jennybc opened this issue Aug 24, 2016 · 7 comments
Closed

Helper to manage Remotes #1304

jennybc opened this issue Aug 24, 2016 · 7 comments
Labels
feature a feature request or enhancement usethis

Comments

@jennybc
Copy link
Member

jennybc commented Aug 24, 2016

It would be nice to have a Remotes helper. Or maybe use_package() could help with this.

@hadley
Copy link
Member

hadley commented Nov 3, 2016

@gaborcsardi would you consider adding remotes helpers to desc?

@hadley hadley added feature a feature request or enhancement install labels Nov 3, 2016
@gaborcsardi
Copy link
Member

Sure, makes sense, I was already thinking about it. How about

  • get_remotes()
  • set_remotes(remotes)
  • add_remotes(remotes)
  • del_remotes(pattern)
  • clear_remotes()
    ?

This basically matches the other helpers in desc, e.g. for URL.

@hadley
Copy link
Member

hadley commented Nov 4, 2016

Yeah, I like it.

@gaborcsardi
Copy link
Member

gaborcsardi commented Nov 4, 2016

Actually, I am writing this now, and you would also need sg that updates a location, because it happens relatively often that you specify a (different) tag or hash for an existing remote. So I'll add

  • update_remotes(remotes)

as well. This is more work, as I need to parse the location to see which one needs to be updated.

Or maybe add_remotes() should just handle this automatically, and update instead of just append.

Also, it makes sense to warn if a remote is added but the package is not in any of the dependency fields.

@gaborcsardi
Copy link
Member

OK, I'll leave out the updating part for now, there is no proper API for it anywhere.....

@gaborcsardi
Copy link
Member

There is an implementation in r-lib/desc@dc6d680

@lock
Copy link

lock bot commented Sep 18, 2018

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Sep 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature a feature request or enhancement usethis
Projects
None yet
Development

No branches or pull requests

4 participants