-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invoke R callbacks in pure R #108
Comments
I'm very strongly interested in this, since I have a package that issues warnings via |
@atheriel I started work on this several months ago but I didn't have time to finish. Unfortunately I won't have time to get to it probably for the rest of the year. The branch is |
@wch I don't see |
@dselivanov Sorry, I forgot to push the branch before. It's there now. |
I wanted to ask whether this change is still planned? Not being able to handle conditions is painful... |
Consider rewriting
execCallback
to not invoke R-based callbacks with our own C/C++ code on the call stack. This would remove our invocation of R_TopLevelExec which causes issues withwithCallingHandlers
(likeexpect_warning
).We could rewrite
execCallback
to only take the callback in C++, and return control to R which will invoke it. There will be some challenge here to maintain the do/while loop logic without inadvertently introducing changes.The text was updated successfully, but these errors were encountered: