Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ast layers display as 'X' on Windows #7

Closed
tpsteiner opened this issue Feb 3, 2018 · 3 comments
Closed

ast layers display as 'X' on Windows #7

tpsteiner opened this issue Feb 3, 2018 · 3 comments

Comments

@tpsteiner
Copy link

tpsteiner commented Feb 3, 2018

'X' makes it hard to read. The blocks on linux/mac looks much better. I think the windows font problem was recently fixed in the skimr package.

Edit: Here is the skimr code to fix windows unicode https://github.com/ropenscilabs/skimr/blob/master/R/utils.R

@hadley
Copy link
Member

hadley commented Mar 6, 2018

Can you please explain the problem?

@hadley hadley closed this as completed in 9cfd404 Mar 7, 2018
@tpsteiner
Copy link
Author

The node output shape on Windos OS was "X", now it is "o". The block shape character is used on mac and linux OS. It's not much of a problem now though, just inconsistent output between operating systems.

Here's a reprex with the updated "o" shape:


lobstr::ast(25 + 30 * 2)
#> o-`+` 
#> +-25 
#> \-o-`*` 
#>   +-30 
#>   \-2

@hadley
Copy link
Member

hadley commented Mar 9, 2018

That's because windows can't reliably display non-ASCII characters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants