Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix formatting on Windows #67

Closed
krlmlr opened this issue Nov 16, 2017 · 3 comments
Closed

Fix formatting on Windows #67

krlmlr opened this issue Nov 16, 2017 · 3 comments

Comments

@krlmlr
Copy link
Member

krlmlr commented Nov 16, 2017

especially R-devel. Known output tests differ. Ideally, we'd be able to recreate the same output on Windows and Linux with LC_CTYPE=C or LC_CTYPE=latin1.
@krlmlr
Copy link
Member Author

krlmlr commented Jan 14, 2018

testthat keeps complaining that output is not UTF-8 encoded. I suspect this is because sink() forcibly converts to native and back on Windows.

@krlmlr
Copy link
Member Author

krlmlr commented May 24, 2018

Addressed in b16963b, all tests were reenabled.

@krlmlr krlmlr closed this as completed May 24, 2018
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2020

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@krlmlr