-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Figure path in Readme gets relocated #1943
Comments
Yes, that's where figures go; there's no Instead of:
You need
That will work locally, and will be automatically relocated on your site. |
If you look at this example here: https://github.com/wkdavis/rpkgreprex/runs/4408853389?check_suite_focus=true, at the very end of the "Create Website" step you can see this warning message:
I'm not sure what the purpose of this warning message is, because the image is in |
Sorry, my bad. This worked fine. Thanks for the reply! |
It seems like this test is testing that figure paths to
man/figures
are relocated toreference/figures
which breaks any figure in the Readme that links toman/figures
pkgdown/tests/testthat/test-build-articles.R
Lines 8 to 28 in 9b17511
I don't know how to provide a reprex for this so I link to the Readme.md of my pkgdown site and the corresponding html.
The readme links to
man/figures
https://github.com/nflverse/nflfastR/blob/e5928b49622469d183d19d6a9dbc7399bf163f30/README.md?plain=1#L106
while the actual html links to
reference/figures
https://github.com/nflverse/nflfastR/blob/c2fd9e9c3a2cd987a5f973cefca551c9773731d7/index.html#L190
The text was updated successfully, but these errors were encountered: