Bootstrap 5 color for inline code is extremely bright and not consistent with code blocks

[DavisVaughan]

With the bootstrap 5 theme (and not using tidytemplate), we get an extremely bright default blue color. I personally feel it is a bit too harsh:

It is also inconsistent with the blue color used for code blocks (I like that blue a lot more):

From Hadley:

basically what you are asking for is for code to get the same colour as span.kw. The inconsistency arises because the blue in inline code comes from the bs4 primary colour and the blue colour in code blocks comes from the syntax highlighting theme

[hadley]

I think we can resolve by setting also setting foreground and background colours for bare code in syntax-highlight.R from the Keyword class.

[DavisVaughan]

I think this should also fix this issue where in tidymodels we use a primary color but it doesn't show up in the code blocks?

[hadley]

@DavisVaughan yeah, because the primary colour doesn't affect syntax highlighting in <pre> blocks.

[jplecavalier]

@DavisVaughan the arrow-light highlight theming (default) override the pre background color. An easy fix would be to create a pkgdown/extra.scss file and define the following

pre {background-color: $code-bg}

Another option would be to choose a theme that is not overwriting the pre background color as atom-one-light.

[hadley]

I think I've decided to make inline code links match the styling of inline code, for the same reason that the styling of code block links matches the styling of code — the links are supposed to be an optional extra that takes you to additional details if you want them, not to be as prominent as a regular link.

[DavisVaughan]

Looks good to me. Here is a tidymodels example and a bootstrap 5 (non tidytemplate) example. Both look good to me. Agree about them being code first, link second - and they shouldn't get in the way of you reading the paragraph.

(Ignore my direct link to purrr::map() in the second one)

[hadley]

Why is one purrr:map() bright blue on the slider readme? Is that a link you added by hand?

[DavisVaughan]

Yes