Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should footer include pkgdown version? #876

Closed
hadley opened this issue Nov 8, 2018 · 2 comments
Closed

Should footer include pkgdown version? #876

hadley opened this issue Nov 8, 2018 · 2 comments

Comments

@hadley
Copy link
Member

@hadley hadley commented Nov 8, 2018

(including sha if installed from GitHub)

This would make it easier to quickly verify that a bug report is for the latest version.

@jayhesselberth what do you think?

@hadley hadley changed the title Should footer include pkgdown version Should footer include pkgdown version? Nov 8, 2018
@jayhesselberth
Copy link
Collaborator

@jayhesselberth jayhesselberth commented Nov 8, 2018

Sounds reasonable to me. I would suggest something like:

For sites built with CRAN pkgdown: Site built with pkgdown (1.1.0)
For sites build with a dev version: Site built with pkgdown (1.1.0.9000@sha)

And maybe the versions should link to CRAN or to the specific github version?

@hadley
Copy link
Member Author

@hadley hadley commented Nov 12, 2018

If we do this, it's basically the kiss of death for reviewing html diffs in pkgdown itself. Are you ok with that?

@hadley hadley closed this in 11facef Nov 20, 2018
@hadley hadley added this to the pkgdown 1.2.0 milestone Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants