Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parameter clash for pkgdown: as_is: true #955

Closed
GregorDeCillia opened this issue Jan 8, 2019 · 2 comments
Closed

parameter clash for pkgdown: as_is: true #955

GregorDeCillia opened this issue Jan 8, 2019 · 2 comments

Comments

@GregorDeCillia
Copy link

GregorDeCillia commented Jan 8, 2019

Hello,

I am currently building vignettes for a package and run into issues when I try to use

---
pkgdown:
   as_is: true
output: html_vignette
---

together with a custom theme in _pkgdown.yml. It seems that the pkgdown theme is passed to the html_vignette function. However, html_vignette throws an error when the theme parameter is used.

Error in html_document(fig_width = fig_width, fig_height = fig_height, :
formal argument "theme" matched by multiple actual arguments
Calls: ... create_output_format -> do.call -> -> output_format
Execution halted

This error message is explained in detail in rstudio/rmarkdown#1110. Despite this issue being marked as solved, the only changes on the rmarkdown side was to update the documentation. Can this be resolved in pkgdown or should I issue this in the rmarkdown repository?

@hadley
Copy link
Member

hadley commented May 17, 2019

If you use as_is: true you're responsible for making an RMarkdown theme that works. Unfortunately we just don't have the resources to support every possible combination.

@GegznaV
Copy link

GegznaV commented Jun 21, 2020

Unfortunately we just don't have the resources to support every possible combination.

You shouldn't support all possible combinations, but I think that there should be a possibility to use html_vignette in pkgdown with as_is: true. I created PR #1352 to address this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants