-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make build_home_index() use content-home template (#787) #834
Conversation
tests/testthat/assets/home-index-template-md/inst/pkgdown/templates/content-home.html
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jayhesselberth do you think this is good to merge?
Looks good to me. |
Great! Looks like appveyor is having trouble installing some packages though. Relatedly https://greta-stats.org is a custom pkgdown build with an Rmd home doc, and a custom home template (with quite a lot of html & css fiddling). It was built using this branch, but I'd be very happy for it to be an example on the pkgdown home page once this is merged. If you're keen, let me know and I'll open a PR to add a line to the pkgdown README.Rmd. |
Can you please add a bullet to NEWS? It should briefly describe the change and end with (Then I'll merge) |
e8ec2b6
to
b878a63
Compare
Done |
As discussed in #787: the content-home.html template was being ignored when a .Rmd file was used for the index page content (ie. index.Rmd or README.Rmd, as opposed to index.md or README.md). Instead, the .Rmd was rendered as an article.
This PR:
rmarkdown_template()
to take names other than 'article', and passing the Rmarkdown content through to pandoc by substituting the whisker variable{{index}}
with the pandoc variable$body$
The two tests that are added in this PR are successful, but there are two failing tests (and two other warnings) on the master branch already, so I expect the travis checks to fail.