Avoid reading active bindings when printing #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| stop("Sorry this is a read-only variable.") | ||
| else { | ||
| # In "getter" role | ||
| if (x < 0) stop("The requested value is not available.") |
|
Thanks! I have just a few minor comments. |
|
yeah, there's more than one way to skin a cat (ugly proverb). Anyway, I am glad you like it. |
|
@oscardelama Once the comments are addressed (you can add another commit and push), I'll merge this PR. |
|
Oops. Sorry if I look rather slow. I am a noob in this matters. This is my first pull request and I didn't figure out what was the next step. I understand I should align my fork with your comments and that's it. Am I right? |
|
@oscardelama Update your code, commit and push. That's all you need to do. |
|
OK guys. Its ready. I love the palindromic commit number '111a111' !! |
wch
added a commit
that referenced
this pull request
Jan 6, 2015
Avoid reading active bindings when printing
|
Thanks! |
|
Thanks to you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including the fix and extending a test case