Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remotes loads packages in standalone mode #548

Closed
gaborcsardi opened this issue Oct 22, 2020 · 1 comment
Closed

remotes loads packages in standalone mode #548

gaborcsardi opened this issue Oct 22, 2020 · 1 comment
Labels
bug an unexpected problem or unintended behavior

Comments

@gaborcsardi
Copy link
Member

I would think that it shouldn't.

> loadedNamespaces()
[1] "compiler"  "graphics"  "utils"     "grDevices" "stats"     "datasets"
[7] "methods"   "base"
> Sys.getenv("R_REMOTES_STANDALONE")
[1] "true"
> remotes::install_github("r-lib/testthat", update = FALSE)
Using bundled GitHub PAT. Please add your own PAT to the env var `GITHUB_PAT`
Downloading GitHub repo r-lib/testthat@HEAD
These packages have more recent versions available.
It is recommended to update all of them.
Which would you like to update?

 1: All
 2: CRAN packages only
 3: None
 4: rlang     (0.4.7        -> 0.4.8       ) [CRAN]
 5: tibble    (3.0.3        -> 3.0.4       ) [CRAN]
 6: backports (1.1.9        -> 1.1.10      ) [CRAN]
 7: diffobj   (0.3.0        -> 0.3.2       ) [CRAN]
 8: waldo     (5e5b7dc30... -> 63bbe3ff7...) [GitHub]
 9: jsonlite  (1.7.0        -> 1.7.1       ) [CRAN]
10: brio      (1.0.0        -> 1.1.0       ) [CRAN]

Enter one or more numbers, or an empty line to skip updates:3
Installing 2 packages: digest, vctrs
Installing packages into 'C:/Users/csard/R/win-library/4.0'
(as 'lib' is unspecified)

  There is a binary version available but the source version is later:
       binary source needs_compilation
digest 0.6.25 0.6.26              TRUE

Do you want to install from sources the package which needs compilation? (Yes/no/cancel) no
trying URL 'https://cloud.r-project.org/bin/windows/contrib/4.0/digest_0.6.25.zip'
Content type 'application/zip' length 244703 bytes (238 KB)
downloaded 238 KB

trying URL 'https://cloud.r-project.org/bin/windows/contrib/4.0/vctrs_0.3.4.zip'
Content type 'application/zip' length 1189974 bytes (1.1 MB)
downloaded 1.1 MB

package 'digest' successfully unpacked and MD5 sums checked
Error: Failed to install 'testthat' from GitHub:
  (converted from warning) cannot remove prior installation of package 'digest'
> loadedNamespaces()
 [1] "processx"    "compiler"    "assertthat"  "R6"          "cli"
 [6] "graphics"    "prettyunits" "tools"       "withr"       "glue"
[11] "utils"       "grDevices"   "crayon"      "remotes"     "stats"
[16] "fansi"       "datasets"    "callr"       "methods"     "ps"
[21] "pkgbuild"    "base"
@jimhester
Copy link
Member

Looks like we are missing a !is_standalone() check in this conditional

if (has_package("pkgbuild")) {

@jimhester jimhester added the bug an unexpected problem or unintended behavior label Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug an unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

2 participants