Send auth information in the headers #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of sending it in query parameters. This way it is not printed in the logs on errors. Also refactored the download code a bit. We still respect the user's `download.file.method` option. We have tests now for the various download methods. Closes #364.
We need to unset the `download.file.method` while running the tests, in case the user running the tests has a default set.
|
@jimhester do not merge yet pls, tests on Windows are failing.... |
|
OK, there is a slight problem. We cannot send headers with the wininet method on R versions older than R 3.6.0. Apparently the user agent trick does not work there. |
|
Since 3.2.x the Windows builds have libcurl, so this is not a major issue. I will add a warning if the user selected "wininet" on an older version of R and headers are needed. |
Need to double quote, single quote is not special on Windows.
|
Actually, we always require the curl package if R is older than 3.2.0, so this hardly ever comes up. Still, I'll add a warning for this rare case. |
Older R versions cannot send headers with the wininet method.
|
OK, I think this is ready. The download code is pretty clean now. |
|
Cool, looks good, thanks for working on this! |
[ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of sending it in query parameters.
This way it is not printed in the logs on errors.
Also refactored the download code a bit. We still respect
the user's
download.file.methodoption.We have tests now for the various download methods.
Closes #364.