Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send GH tokens in headers, instead of query parameters #364

Closed
gaborcsardi opened this issue May 9, 2019 · 0 comments · Fixed by #391
Closed

Send GH tokens in headers, instead of query parameters #364

gaborcsardi opened this issue May 9, 2019 · 0 comments · Fixed by #391
Labels
feature a feature request or enhancement

Comments

@gaborcsardi
Copy link
Member

With the user agent hack before 3.6.0.

To avoid exposing them when the URL is printed in error messages, etc.
@jimhester jimhester added the feature a feature request or enhancement label May 22, 2019
gaborcsardi added a commit that referenced this issue Jun 24, 2019
@gaborcsardi
Send auth information in the headers
c66bc04 
Instead of sending it in query parameters.
This way it is not printed in the logs on errors.

Also refactored the download code a bit. We still respect
the user's `download.file.method` option.

We have tests now for the various download methods.

Closes #364.
@gaborcsardi gaborcsardi mentioned this issue Jun 24, 2019
Merged
jimhester pushed a commit that referenced this issue Jun 24, 2019
@gaborcsardi @jimhester
Send auth information in the headers (#391)
0c980e2 
* Send auth information in the headers

Instead of sending it in query parameters.
This way it is not printed in the logs on errors.

Also refactored the download code a bit. We still respect
the user's `download.file.method` option.

We have tests now for the various download methods.

Closes #364.

* Fix download test if user has method set

We need to unset the `download.file.method`
while running the tests, in case the user
running the tests has a default set.

* Update install-github.R file

* Fix download tests on windows

Need to double quote, single quote is
not special on Windows.

* Warn if cannot send HTTP headers

Older R versions cannot send headers with
the wininet method.

* Update install-github.R file

* Add note to NEWS

[ci skip]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature a feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Send auth information in the headers r-lib/remotes
2 participants
@jimhester @gaborcsardi