API change: new argument verbose for style_*()

[lorenzwalthert]

Migrated from #374 (comment).

This may be helpful if stylers are called from within other functions. Alternative: Let developers capture output in these functions and storing them in an object that they will throw away.

silent_style_file <- function(...) {
  msg <- capture.output(style_file(...))

}

@krlmlr what do you think?

[krlmlr]

Agreed. I've seen quiet = FALSE in other (especially tidyverse) packages. Not sure how useful it is to capture the output, when the caller could do that himself.

[lorenzwalthert]

Agree, let's keep the API slim. I think 90% of the people who would want to use this option are developers and they can write a wrapper around it.

[krlmlr]

I don't mind a quiet = FALSE argument, though.

[lorenzwalthert]

Ok, so I might have gotten you wrong here

Not sure how useful it is to capture the output, when the caller could do that himself.

Because I thought that speaks against an additional argument quiet.

[krlmlr]

I thought quiet = TRUE wouldn't involve calling capture.output().

[lorenzwalthert]

If we implement it, sure. But what I showcased above was a way a user / developer can avoid any command line output with the current CRAN version (v1.0.1) of styler.

[krlmlr]

quiet = TRUE feels better than asking the caller to capture and then discard our output.

[lorenzwalthert]

ok.