Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip() without message #1586

Closed
ms609 opened this issue Mar 4, 2022 · 0 comments · Fixed by #1761
Closed

skip() without message #1586

ms609 opened this issue Mar 4, 2022 · 0 comments · Fixed by #1761
Labels
feature a feature request or enhancement skip
Milestone
3.1.8

Comments

@ms609
Copy link

ms609 commented Mar 4, 2022

Currently, if I include the line skip() in a testthat test file, I see

Error in `paste0(message, collapse = "\n")`: argument "message" is missing, 
  with no default

I had expected skip() to simply skip the test without specifying a message.

Is it possible to specify a more user-friendly behaviour for skip() if no message parameter is passed, either by specifying a NULL default, or by using an if (missing(message)) check?
I'd be happy to suggest a PR if helpful.
@hadley hadley added feature a feature request or enhancement skip labels Sep 19, 2022
@hadley hadley added this to the 3.1.8 milestone Mar 23, 2023
hadley added a commit that referenced this issue Mar 29, 2023
@hadley
Skipping overhaul
bf47f15 
* Use `IS_BIOC_BUILD_MACHINE` for `skip_on_bioc()`. Fixes #1712.
* `skip()` gains default message. Fixes #1586
* Overhaul testing and get as close as possible to 100% test coverage.
* Replace mockery with `local_mocked_bindings()`.
* Move superseded skips to own doc.
@hadley hadley mentioned this issue Mar 29, 2023
Merged
@hadley hadley closed this as completed in 95635f6 Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature a feature request or enhancement skip
Projects
None yet
Milestone
3.1.8
Development

Successfully merging a pull request may close this issue.

Skipping overhaul r-lib/testthat
2 participants
@hadley @ms609