Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use IS_BIOC_BUILD_MACHINE rather than BBS_HOME in skip_on_bioc() #1712

Closed
mtmorgan opened this issue Nov 7, 2022 · 0 comments · Fixed by #1761
Closed

Use IS_BIOC_BUILD_MACHINE rather than BBS_HOME in skip_on_bioc() #1712

mtmorgan opened this issue Nov 7, 2022 · 0 comments · Fixed by #1761
Labels
bug an unexpected problem or unintended behavior skip
Milestone
3.1.8

Comments

@mtmorgan
Copy link

mtmorgan commented Nov 7, 2022

https://bioconductor.org/checkResults/3.16/bioc-LATEST/Renviron.bioc (and the current 'devel' builds) defines IS_BIOC_BUILD_MACHINE=true to replace use of the ad hoc and undocumented BBS_HOME.
@hadley hadley added bug an unexpected problem or unintended behavior skip labels Mar 23, 2023
@hadley hadley added this to the 3.1.8 milestone Mar 23, 2023
hadley added a commit that referenced this issue Mar 29, 2023
@hadley
Skipping overhaul
bf47f15 
* Use `IS_BIOC_BUILD_MACHINE` for `skip_on_bioc()`. Fixes #1712.
* `skip()` gains default message. Fixes #1586
* Overhaul testing and get as close as possible to 100% test coverage.
* Replace mockery with `local_mocked_bindings()`.
* Move superseded skips to own doc.
@hadley hadley mentioned this issue Mar 29, 2023
Merged
hadley added a commit that referenced this issue Apr 5, 2023
@hadley
Skipping overhaul (#1761)
95635f6 
* Use `IS_BIOC_BUILD_MACHINE` for `skip_on_bioc()`. Fixes #1712.
* `skip()` gains default message. Fixes #1586.
* Overhaul testing and get as close as possible to 100% test coverage.
* Replace mockery with `local_mocked_bindings()`.
* Move superseded skips to own doc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug an unexpected problem or unintended behavior skip
Projects
None yet
Milestone
3.1.8
Development

Successfully merging a pull request may close this issue.

Skipping overhaul r-lib/testthat
2 participants
@hadley @mtmorgan