Skipping overhaul #1761
Merged
Skipping overhaul #1761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavisVaughan
approved these changes
Mar 30, 2023
| @@ -48,7 +48,7 @@ | |||
| #' expect_equal(1, 2) # this one skipped | |||
| #' expect_equal(1, 3) # this one is also skipped | |||
| #' }) | |||
| skip <- function(message) { | |||
| skip <- function(message = "Skipping") { | |||
There was a problem hiding this comment.
I don't love providing a default message, I feel like if you call skip() then you should justify yourself with a good message
I don't feel extremely strong about this though
jennybc
approved these changes
Mar 30, 2023
R/skip.R
Outdated
Comment on lines
125
to
129
| if (!has_internet(host)) { | ||
| skip("offline") | ||
| } else { | ||
| invisible() | ||
| } |
There was a problem hiding this comment.
Nitpick, but I try to avoid negating the condition when I can.
Suggested change
| if (!has_internet(host)) { | |
| skip("offline") | |
| } else { | |
| invisible() | |
| } | |
| if (has_internet(host)) { | |
| invisible() | |
| } else { | |
| skip("offline") | |
| } |
There was a problem hiding this comment.
Given that we already have the skip_if() and skip_if_not() helpers that do this, I just refactored to use them in more places.
Co-authored-by: Davis Vaughan <davis@rstudio.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IS_BIOC_BUILD_MACHINEforskip_on_bioc(). Fixes UseIS_BIOC_BUILD_MACHINErather thanBBS_HOMEinskip_on_bioc()#1712.skip()gains default message. Fixesskip()withoutmessage#1586local_mocked_bindings().@DavisVaughan @jennybc no need for a detailed review, but I'd love your thoughts on how the tests look now, and if you see any other obvious low hanging fruit.