Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cli errors or file an issue if you don't have time to do it now #39

Open
Tracked by #38
gaborcsardi opened this issue Nov 3, 2023 · 4 comments
Open
Tracked by #38
Labels
upkeep maintenance, infrastructure, and similar

Comments

@gaborcsardi
Copy link
Member

No description provided.

@gaborcsardi gaborcsardi added the upkeep maintenance, infrastructure, and similar label Nov 4, 2023
@cicdguy
Copy link

cicdguy commented Dec 15, 2023

Would this involve adding a non-zero exit code for URLs that are non-conformant?

@gaborcsardi
Copy link
Member Author

No, but you can do that already, like this:

❯ R -q -e 'if (nr <- nrow(print(urlchecker::url_check()))) stop(nr, " bad URL(s)")'
> if (nr <- nrow(print(urlchecker::url_check()))) stop(nr, " bad URL(s)")
✖ Error: DESCRIPTION:14:65 404: Not Found
URL: https://github.com/r-lib/ps#readme, https://ps.r-lib.org/, https://httpbin.org/status/404
                                                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Error: 1 bad URL(s)
Execution halted
❯ echo $?
1

If this is what you meant.

@cicdguy
Copy link

cicdguy commented Dec 15, 2023

Yeah that's exactly what I was referring to.

Was hoping this would be sort of built-in and controlled via a parameter to url_check, but this works too.

Thanks!

@gaborcsardi
Copy link
Member Author

We can add an argument to fail I guess, can you please open an issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upkeep maintenance, infrastructure, and similar
Projects
None yet
Development

No branches or pull requests

2 participants