Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use_gitlab() #567

Closed
overmar opened this issue Jan 11, 2019 · 3 comments
Closed

use_gitlab() #567

overmar opened this issue Jan 11, 2019 · 3 comments

Comments

@overmar
Copy link
Contributor

overmar commented Jan 11, 2019

use_gitlab() in the same vein as use_github()
Originally posted by @LDalby in #293 (comment)

@overmar
Copy link
Contributor Author

overmar commented Jan 11, 2019

I can put in a pull request to do allow for doing all of the use_* github things with gitlab. But need to essentially copy the gh library, and make a couple of changes, primarily to the errors, and environment variables. It seems really wasteful and although the license says that you can do it, I wonder if there is a better suggestion how to handle this?

@jennybc
Copy link
Member

jennybc commented Jan 11, 2019

The gitlab partner issue of #293 re: bitbucket.

@overmar No, we would not accept the gitlab equivalent of gh here in usethis. So a hypothetical use_gitlab() function would need to inline what it needs, if it can be made concise. Or if there was a gitlab equivalent of gh on CRAN, the hypothetical use_gitlab() function could use it and it would appear in Suggests here.

Just to characterize the situation: The folks who maintain usethis are currently all-in on GitHub, not Gitlab or Bitbucket. Hence the asymmetry. As it stands, maintaining the GitHub connectivity here has a huge payoff for us directly and for the community. We also maintain gh. The situation is much less clear for Gitlab and Bitbucket. So we would be reluctant to take a large piece of code or new dependencies for this.

@overmar
Copy link
Contributor Author

overmar commented Jan 11, 2019

@jennybc thats fair. Thank you for the explanation. My question about gh was more so related to the fact that the authors of this package are also authors of that package. I will see if I can make small changes that would get it to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants