Better create_from_github() #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes @215 * Clones from the ssh or https url (vs the git url), which stores the correct URL for origin remote * Better logic re: forking * Adds upstream remote in case of fork * Allows token, credentials, host to be specified
jennybc
force-pushed
the
better-create-from-github
branch
from
3937ef8
to
ecb8607
Compare
In particular, do this before creating a fork
hadley
approved these changes
Feb 15, 2018
| #' repositories. | ||
| #' Creates a new local Git repository from a repository on GitHub. It is highly | ||
| #' recommended that you pre-configure or pass a GitHub personal access token | ||
| #' (PAT) as described in [gh::gh_whoami()]. In particular, a PAT is required in |
There was a problem hiding this comment.
Are you planning to add any PAT help for this release?
There was a problem hiding this comment.
Yes, I plan to tackle that next.
R/create.R
Outdated
| owner <- repo_info$owner$login | ||
|
|
||
| if (is.na(fork)) { | ||
| if (pat_available) { |
There was a problem hiding this comment.
fork <- pat_available && !isTRUE(perms$push)
?
R/github.R
Outdated
| #' fields with appropriate links (unless they already exist). | ||
| #' `use_github()` requires that your package have a git repository, which you | ||
| #' can create with [use_git()], if needed. `use_github()` then sets up | ||
| #' appropriate git remotes and syncs. `use_github_links()` populates the `URL` |
R/github.R
Outdated
| #' public and private keys are in the default locations, `~/.ssh/id_rsa.pub` | ||
| #' and `~/.ssh/id_rsa`, respectively, and that `ssh-agent` is configured to | ||
| #' manage any associated passphrase. Alternatively, specify a | ||
| #' [git2r::cred_ssh_key()] object via the `credentials` parameter. |
There was a problem hiding this comment.
Cross-link to relevant happy git with R section?
|
I acted on all the small comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #215
create_from_github()should share many arguments withuse_github()Fixes #214 GitHub connectivity
I think this completes the obvious set of GitHub operations a typical user would expect. At least in terms of project initiation.
originremote, i.e. pull/push should now work going forwardupstreamremote in case of fork, also honouring ssh vs https protocol