Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better create_from_github() #253

Merged
merged 8 commits into from
Feb 15, 2018
Merged

Better create_from_github() #253

merged 8 commits into from
Feb 15, 2018

Commits on Feb 14, 2018

  1. Strong, clear words about PAT; introduce new args

    @jennybc
    jennybc committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    dbd5c26 View commit details
    Browse the repository at this point in the history

  2. Add rationalize_fork()

    @jennybc
    jennybc committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    38e4795 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2018

  1. Major upgrade of create_from_github() 

    Fixes @215

  * Clones from the ssh or https url (vs the git url), which stores the correct URL for origin remote
  * Better logic re: forking
  * Adds upstream remote in case of fork
  * Allows token, credentials, host to be specified
    @jennybc
    jennybc committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    ecb8607 View commit details
    Browse the repository at this point in the history

  2. Record some of my manual testing

    @jennybc
    jennybc committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    60860ea View commit details
    Browse the repository at this point in the history

  3. Fail early if repo_path exists and is not empty 

    In particular, do this before creating a fork
    @jennybc
    jennybc committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    30b1f29 View commit details
    Browse the repository at this point in the history

  4. Use pat vs. falling back to env vars

    @jennybc
    jennybc committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    b4a238f View commit details
    Browse the repository at this point in the history

  5. Simplify logic when fork = NA

    @jennybc
    jennybc committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    e27b6c3 View commit details
    Browse the repository at this point in the history

  6. Work on docs re: github

    @jennybc
    jennybc committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    e9fefa6 View commit details
    Browse the repository at this point in the history