Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upcoming R version might break nvimcom #167

Closed
PMassicotte opened this issue Jul 2, 2024 · 7 comments · Fixed by #168
Closed

Upcoming R version might break nvimcom #167

PMassicotte opened this issue Jul 2, 2024 · 7 comments · Fixed by #168

Comments

@PMassicotte
Copy link
Collaborator

dgkf/debugadapter#16 (comment)

@jalvesaq do you have an idea?

@PMassicotte
Copy link
Collaborator Author

If this can be fixed, we are going to have a functional DAP inside neovim for R!

@jalvesaq
Copy link
Member

jalvesaq commented Jul 2, 2024

I will see this now...

@jalvesaq
Copy link
Member

jalvesaq commented Jul 2, 2024

We can manually build nvimcom in a terminal emulator because the function Rf_removeTaskCallbackByName is still declared in include/R_ext/Callbacks.h, but it is not available at run time and, consequently, when loading nvimcom, we get the error:

undefined symbol: Rf_removeTaskCallbackByName

@PMassicotte
Copy link
Collaborator Author

This is a bit out of my expertise. What does it mean exactly? Does it mean that there is a discrepancy between declaration and availability of some kind of function?

@jalvesaq
Copy link
Member

jalvesaq commented Jul 2, 2024

Yes, it's a bug in R-devel. Probably, they removed the function on purpose but forgot to remove its declaration from the corresponding header file. We can report the bug and, then, they will either bring the function back or remove the declaration. Although no longer available in C, the function is still available in the R language. I will see if we can use it from R (not C).

@jalvesaq
Copy link
Member

jalvesaq commented Jul 2, 2024

I moved the C code to R at the branch https://github.com/R-nvim/R.nvim/tree/R_task

@PMassicotte
Copy link
Collaborator Author

wow you are fast (wish I had your skills!)

So far so good, I am using it. Let me try to configure dap.

jalvesaq added a commit that referenced this issue Jul 3, 2024
Close #167
Also: avoid one of the R CRAN check warnings.
jalvesaq added a commit to jalvesaq/Nvim-R that referenced this issue Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants