Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: update GDAL 3.4.1 for R < 4.2 #1919

Merged
merged 1 commit into from Mar 15, 2022
Merged

Windows: update GDAL 3.4.1 for R < 4.2 #1919

merged 1 commit into from Mar 15, 2022

Conversation

jeroen
Copy link
Contributor

@jeroen jeroen commented Mar 15, 2022

Wrap-up GDAL update for R 3.3.0 - 4.1.3 on Windows. Also adds support for zstd tiff files. This update does not affect the new R-4.2 ucrt builds which you have hardcoded separately in src/Makevars.ucrt.

@rsbivand
Copy link
Member

rsbivand commented Mar 15, 2022

Thanks! Curiously, 3.4.2 was just released. The big bump will be 3.6; 3.5 is coming soon and will have both cmake and configure, 3.6 drops configure, like GEOS 3.10 and PROJ 9.

The edits to src/Makevars.win have been copied into rgdal. Unfortunately, your PR reached me just after I submitted a new version to CRAN; I'll commit to R-Forge.

@jeroen
Copy link
Contributor Author

jeroen commented Mar 15, 2022

OK great I had also tested this for rgdal and rgeos on all R versions.

If there is interest I can keep providing updates in the future, but it looks like the new cran policies will mandate you use the gdal provided by TK instead of rwinlib for R 4.2 and up. So we'll see.

@rsbivand
Copy link
Member

This is my understanding too. Typically, migration to new R minor versions seems to have been slowing, so I expect 4.1 to be in active use for another year at least. I'm not aware that TK is planning to provide CRAN MXE UCRT support for r-oldrel, so up to the R 4.3 release, R 4.1 will be needed, I think. rwinlib has served the geospatial community very well!

@edzer edzer merged commit 3621c32 into r-spatial:main Mar 15, 2022
@edzer
Copy link
Member

edzer commented Mar 15, 2022

Thanks a lot, @jeroen !!

@jeroen jeroen deleted the rwinlib branch March 15, 2022 13:55
@jeroen
Copy link
Contributor Author

jeroen commented Mar 15, 2022

@rsbivand you committed a typo on rgdal: you commented out some of the old lines, but that does not work with makefiles: a comment line that ends with a \ will comment out the entire block (green is comments):

Screenshot 2022-03-15 at 2 54 14 PM

You can remove the commented lines from the Makevars.win, or alternatively move them out of the definition of PKG_LIBS and PKG_CPPFLAGS?

You can also inspect the build failure on r-universe: https://r-forge.r-universe.dev/

@rsbivand
Copy link
Member

Failed on R-Forge too - fix committed as rev. 1168.

@jeroen
Copy link
Contributor Author

jeroen commented Mar 24, 2022

@rsbivand you may also benefit from this same change in rgeos because the new gdal stack includes geos 3.10.2.

@rsbivand
Copy link
Member

Thanks, rgeos seems to build and check fine on R-forge.

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Jun 4, 2023
# Please note that **rgdal** will be retired during 2023, plan
  transition to sf/stars/terra functions using GDAL and PROJ at your
  earliest convenience (see
  https://r-spatial.org/r/2023/05/15/evolution4.html and earlier blogs
  for guidance).

# Version 1.6-7 (development, rev. 1202-)

* Make retirement in October 2023 explicit, move package start-up
  messages to load from attach

# Version 1.6-6 (2023-04-18, rev. 1200-1201)

* add SharpYuv condition in src/Makevars.ucrt

# Version 1.6-5 (2023-03-02, rev. 1198-1199)

* Upgrade CXX11 to CXX17 (may cause problems for archaic OS)

# Version 1.6-4 (2023-01-12, rev. 1188-1197)

* Update GridsDatums data set

* Warn if retracted GDAL 3.6.0 is being used

* Update `makevars.ucrt` to Rtools 4.3

# Version 1.6-3 (2022-12-14, rev. 1184-1187)

* CRAN error in possibly writing outside tempdir

* CRAN error in printing stored stale `sessionInfo()` output in vignette

# Version 1.6-2 (2022-11-09, rev. 1177-1183)

* deprecation of `project()`, `CRSargs()`, `asSGDF_GROD()`,
  `readGDAL()`, `writeGDAL()`, `create2GDAL()`, `showWKT()`,
  `showEPSG()`, `readOGR()`, `ogrFIDs()`, `ogrInfo()`, `ogrDrivers()`,
  `writeOGR()`, `ogrListLayers()`, `GDALinfo()`, `print.GDALobj()`,
  `GDALcall()`, `rawTransform()`, `OGRSpatialRef()` in favour of
  functions and methods ib **sf** and **terra**.

* handle -Wstrict-prototypes `int main()` to `int main(void)` in
  `configure.ac`

* update `src/Makevars.ucrt` to upgraded MXE geospatial libraries

* address r-spatial/sf#2009 in `src/Makevars.ucrt`

* set PROJ4 warnings default to "none"

* fix -Wstrict-prototypes warnings in code

# Version 1.5-32 (2022-05-09, rev. 1173-1176)

* update src/Makefile.ucrt to accommodate the GDAL raster Geospatial
  PDF driver for reading

# Version 1.5-31 (2022-04-18, rev. 1172)

* unescape underscores in help pages

# Version 1.5-30 (2022-04-08, rev. 1166-1171)

* restore PROJ path assignment for PROJ >= 6 not using PROJ_LIB (was
  used for PROJ 6 but not > 6)
  rsbivand/rgrass#52

* Update src/Makevars.win to GDAL 3.4.1 for R < 4.2
  r-spatial/sf#1919

# Version 1.5-29 (2022-03-15, rev. 1159-1165)

* also convert BOUNDCRS to PROJCRS by default in OGRSpatialRef() and
  getProjectionRef()

* test for chunks table in cache.db in vignette

* quietening tests only differing by `proj.db` version.

# Version 1.5-28 (2021-12-15, rev. 1157-1158)

* Adapting to R 4.2 Windows UCRT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants