Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Makevars for Windows #2009

Merged
merged 1 commit into from Oct 11, 2022
Merged

Update Makevars for Windows #2009

merged 1 commit into from Oct 11, 2022

Conversation

brownag
Copy link
Contributor

@brownag brownag commented Oct 7, 2022

When attempting to build sf from source on my work (Windows) computer I get the following error.

cp -r C:/Program Files/rtools42/x86_64-w64-mingw32.static.posix/share/gdal ../inst/
cp: cannot stat 'C:/Program': No such file or directory
cp: cannot stat 'Files/rtools42/x86_64-w64-mingw32.static.posix/share/gdal': No such file or directory
make: *** [Makevars.ucrt:12: winlibs] Error 1
ERROR: compilation failed for package 'sf'

This appears to be because my rtools42 directory is inside "Program Files" which has a space in the name.

I do not have control over where Rtools is installed.

Adding quotes around the cp command paths in Makevars.ucrt resolves the error for me.

I also made an analogous change to Makevars.win.

@kadyb suggested I propose these changes here after making similar ones in {terra}.

@rsbivand
Copy link
Member

Thanks, applied to rgdal on R-Forge for next release.

rsbivand added a commit to rsbivand/sf that referenced this pull request Oct 11, 2022
@edzer edzer merged commit 7d0c10c into r-spatial:main Oct 11, 2022
@edzer
Copy link
Member

edzer commented Oct 11, 2022

Great, thanks!

@brownag brownag deleted the makevars1-brown branch October 11, 2022 15:15
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Jun 4, 2023
# Please note that **rgdal** will be retired during 2023, plan
  transition to sf/stars/terra functions using GDAL and PROJ at your
  earliest convenience (see
  https://r-spatial.org/r/2023/05/15/evolution4.html and earlier blogs
  for guidance).

# Version 1.6-7 (development, rev. 1202-)

* Make retirement in October 2023 explicit, move package start-up
  messages to load from attach

# Version 1.6-6 (2023-04-18, rev. 1200-1201)

* add SharpYuv condition in src/Makevars.ucrt

# Version 1.6-5 (2023-03-02, rev. 1198-1199)

* Upgrade CXX11 to CXX17 (may cause problems for archaic OS)

# Version 1.6-4 (2023-01-12, rev. 1188-1197)

* Update GridsDatums data set

* Warn if retracted GDAL 3.6.0 is being used

* Update `makevars.ucrt` to Rtools 4.3

# Version 1.6-3 (2022-12-14, rev. 1184-1187)

* CRAN error in possibly writing outside tempdir

* CRAN error in printing stored stale `sessionInfo()` output in vignette

# Version 1.6-2 (2022-11-09, rev. 1177-1183)

* deprecation of `project()`, `CRSargs()`, `asSGDF_GROD()`,
  `readGDAL()`, `writeGDAL()`, `create2GDAL()`, `showWKT()`,
  `showEPSG()`, `readOGR()`, `ogrFIDs()`, `ogrInfo()`, `ogrDrivers()`,
  `writeOGR()`, `ogrListLayers()`, `GDALinfo()`, `print.GDALobj()`,
  `GDALcall()`, `rawTransform()`, `OGRSpatialRef()` in favour of
  functions and methods ib **sf** and **terra**.

* handle -Wstrict-prototypes `int main()` to `int main(void)` in
  `configure.ac`

* update `src/Makevars.ucrt` to upgraded MXE geospatial libraries

* address r-spatial/sf#2009 in `src/Makevars.ucrt`

* set PROJ4 warnings default to "none"

* fix -Wstrict-prototypes warnings in code

# Version 1.5-32 (2022-05-09, rev. 1173-1176)

* update src/Makefile.ucrt to accommodate the GDAL raster Geospatial
  PDF driver for reading

# Version 1.5-31 (2022-04-18, rev. 1172)

* unescape underscores in help pages

# Version 1.5-30 (2022-04-08, rev. 1166-1171)

* restore PROJ path assignment for PROJ >= 6 not using PROJ_LIB (was
  used for PROJ 6 but not > 6)
  rsbivand/rgrass#52

* Update src/Makevars.win to GDAL 3.4.1 for R < 4.2
  r-spatial/sf#1919

# Version 1.5-29 (2022-03-15, rev. 1159-1165)

* also convert BOUNDCRS to PROJCRS by default in OGRSpatialRef() and
  getProjectionRef()

* test for chunks table in cache.db in vignette

* quietening tests only differing by `proj.db` version.

# Version 1.5-28 (2021-12-15, rev. 1157-1158)

* Adapting to R 4.2 Windows UCRT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants