Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on ring-core #19

Closed
jeluard opened this issue Jun 18, 2017 · 1 comment
Closed

Remove dependency on ring-core #19

jeluard opened this issue Jun 18, 2017 · 1 comment

Comments

@jeluard
Copy link
Contributor

jeluard commented Jun 18, 2017

ring-cors depends on ring-core for the sole method get-header.

It would be nice to drop this dependency and simply copy the code in ring-cors for 2 reasons:

  • it reduces potential for versions conflict on ring-core
  • ring-core ships with lots of irrelevant transitive dependencies

What do you think? I can create a PR if needed.
@r0man
Copy link
Owner

r0man commented Jun 20, 2017

@jeluard Yes, we can do that. PR welcome!

@r0man r0man closed this as completed in 9a178af Jun 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@r0man @jeluard