Skip to content
This repository has been archived by the owner on Aug 1, 2021. It is now read-only.

Course download finishes without reporting error at the end #477

Closed
geffchang opened this issue Mar 1, 2020 · 4 comments
Closed

Course download finishes without reporting error at the end #477

geffchang opened this issue Mar 1, 2020 · 4 comments
Labels
enhancement New feature or request future-enhancement The feature of request will be implemented in next release

Comments

@geffchang
Copy link

geffchang commented Mar 1, 2020

Describe the bug
This is a feature request, rather than a bug. When you download a course, and there is an error downloading one of the courses in between, but the course finishes successfully, you are not informed at the end that there was an error. If the course download is large (i.e. has many videos / chapters), you may miss this error if you don't scroll up or check the previous progress.

NOTE: There are 2 cases of error: (1) An error happens in between, but the last course finishes successfully. In this case, it's difficult to know there was an error, (2) An error happens in between, and the course also finishes with an error. In this case, you know immediately there is an error.

To Reproduce
Steps to reproduce the behavior:

  1. It will not be easy to replicate this issue. Download a large course, get an error in between, and finish a course.

Expected behavior
At the end of the course download, report any failed downloads (video, subtitle, document, etc). A note that an error occurred may be enough. Optional to add: Number of errors.

Screenshots
Subtitle skipped: https://imgur.com/AYnDkIW
Lecture skipped: https://imgur.com/ASkqUxq

Python Environment (please complete the following information):

  • OS Platform: Windows 10
  • Python Version 3.8.0

Additional context
Add any other context about the problem here.

@r0oth3x49
Copy link
Owner

hmm that is most of the time case with subtitles as the direct url gets expired for some reason, will add some mechanism to show the total of errors at the end of course

@geffchang
Copy link
Author

geffchang commented Mar 5, 2020

@r0oth3x49 It can also happen with a lecture. I updated the screenshots; I got it just a while ago.

@r0oth3x49 r0oth3x49 added enhancement New feature or request future-enhancement The feature of request will be implemented in next release labels Mar 21, 2020
@r0oth3x49
Copy link
Owner

@geffchang in the next version i already have added a proper session management, so this issue will be resolved with next major update.

@geffchang
Copy link
Author

@geffchang in the next version i already have added a proper session management, so this issue will be resolved with next major update.

That sounds great. Looking forward to it! :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request future-enhancement The feature of request will be implemented in next release
Projects
None yet
Development

No branches or pull requests

2 participants