Exporting the excite function to Python #31
Conversation
|
Note: tests are breaking because this is still getting the version of SPTK without the changes I made. I expect these tests to pass as soon as you accept r9y9/SPTK#11. |
|
This is great! I don't have much time right now, but I will review this and r9y9/SPTK#11 in a few days. Thanks! |
|
I will also need the RAPT pitch estimator for my current project, so I'll João Felipe Santos On 21 October 2015 at 08:49, Ryuichi YAMAMOTO notifications@github.com
|
| @@ -2637,6 +2637,18 @@ def mglsadf(x, np.ndarray[np.float64_t, ndim=1, mode="c"] b not None, | |||
|
|
|||
| return _mglsadf(x, &b[0], order, alpha, stage, &delay[0]) | |||
|
|
|||
| ### Excitation ### | |||
| def excite(np.ndarray[np.float64_t, ndim=1, mode = "c"] pitch, frame_period=100, interp_period=1, gaussian=False, seed=1): | |||
There was a problem hiding this comment.
hopsize instead of frame_period? or rename hopsize to frame_period in swipe for naming consistency.
|
Could you add docstrings similar to other functions? The docstrings format in pysptk is under numpydoc style, I believe. In particular, I would like to document what As for the docs, docstrings are automatically retrieved by sphinx and doc is generated if |
|
Now we're just missing docstrings. I'll get that sorted out soon! |
|
@jfsantos Can I merge this? If you don't have time, I can add docstrings after merging. |
|
Sure, please merge it now. We can add docstrings in a separate commit.
Thanks!
|
Exporting the excite function to Python
|
Thanks for your contribution! |
This, together with r9y9/SPTK#11, adds the pulse excitation method from SPTK to pysptk.