Exporting excite as a function instead of a binary #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! A request: Can you rename |
| for (;;) { | ||
| if (freadf(&p2, sizeof(p2), 1, fp) != 1) | ||
| return (0); | ||
| for (int fn = 1; fn < n; fn++) { |
There was a problem hiding this comment.
I guess this line may cause compilation error on MSVC on windows. While I was working on #8, I found MSVC on AppVeyor throws error for C89-imcompatible codes.
There was a problem hiding this comment.
Right, I forgot MSVC still does not have support for C99 (they're only 16 years late!). This is now fixed.
r9y9
added a commit
that referenced
this pull request
Oct 23, 2015
Exporting excite as a function instead of a binary
|
Thanks! |
r9y9
added a commit
to r9y9/SPTK.jl
that referenced
this pull request
Oct 27, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
exciteas a function. I'll be sending a separate PR to pysptk with the Cython part of the code.