Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows build broken #686

Closed
zergud opened this issue Apr 12, 2024 · 2 comments · Fixed by #688
Closed

Windows build broken #686

zergud opened this issue Apr 12, 2024 · 2 comments · Fixed by #688
Labels
bug windows
Milestone
24.3.0

Comments

@zergud
Copy link
Collaborator

zergud commented Apr 12, 2024

Windows build broken after #658

image
@zergud zergud added the bug label Apr 12, 2024
@zergud zergud added this to the 24.3.0 milestone Apr 12, 2024
@ra3xdh ra3xdh added the windows label Apr 12, 2024
@ra3xdh
Copy link
Owner

ra3xdh commented Apr 12, 2024

This has appeared after #658 Linux build is not affected. @wawuwo

@wawuwo
Copy link
Contributor

wawuwo commented Apr 12, 2024

Oh! :(
Working on it, will provide a fix soon

wawuwo added a commit to wawuwo/qucs_s that referenced this issue Apr 12, 2024
@wawuwo
Fix Windows build by replacing absent "QucsHomeDir" settings member
920d70c 
In 72f9e46 all temporary files were moved to a dedicated temp files
dir. To store the name of this dir, a new property named "tempFilesDir"
was introduced and all occurences of "QucsHomeDir" in "temporary file"
contexts were replaced by new property. But in one branch of "ifdef"
preprocessor condition the replacement somehow failed, leaving the
old property name. This commit replaces it with correct one.

Fixes ra3xdh#686
@wawuwo wawuwo mentioned this issue Apr 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug windows
Projects
None yet
Milestone
24.3.0
Development

Successfully merging a pull request may close this issue.

Fix Windows build by replacing absent "QucsHomeDir" settings member wawuwo/qucs_s
3 participants
@zergud @ra3xdh @wawuwo