-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Qucs-S workspace and tempfile paths #658
Conversation
Thanks. I will test this and share the feedback. It's need to use fresh installation to test this. To test VHDL/Verilog you should install |
@ra3xdh I've found a bug: directory for simulator output (which is defined in "Simulator settings") is always set to I'll prepare a fix to respect user-defined setting after restart. But I'm in doubt: if simulator output is temporary data and temporary data should be stored in standard location, then shouldn't there be no way to set custom simulator output dir? |
The user normally should not get access to raw SPICE simulator dataset. The output directory setting was implemented for example to redirect output to ramdisk mounted in |
I see; then I'll adjust simulator settings dialog and revert last fix 🤝 |
This reverts commit 6411ada. There is no need to have user-defined output dirs. Instead of respecting user setting we should instead remove the means to change it and always use standard path. See: ra3xdh#658 (comment)
Simulator output should be stored in generic dir for temporary files, there is no need for user-defined simulator output path and means to define it. See ra3xdh#658 (comment)
I have tested this and found one major issue. The new Qucs-S always sets the project directory to
Probably you can propose a better solution. I will merge this PR after this issue will be resolved. |
Also the solution may be to use new workspace location only on the fresh installation of the application. The |
@ra3xdh, oh, I see :( |
With this commit the root path for temporary files produced by Qucs-S is set to StandardPaths::CacheLocation which is ~/.cache/qucs-s on Linux. This path is set automatically and can't be changed.
This commit 1. changes ~/.qucs to ~/QucsWorkspace 2. assignes more descriptive name to config property which holds this path
With this commit creating of workspace dir is done *after* loading of settings, so the workspace path from settings is taken into account. Previous behaviour was to create workspace dir before loading of settings which led to path from settings to be ignored. See comment: ra3xdh#145 (comment)
Simulator output should be stored in generic dir for temporary files, there is no need for user-defined simulator output path and means to define it. See ra3xdh#658 (comment)
77560b6
to
c40cd6e
Compare
@ra3xdh I implemented it the easy way: if it is a fresh install (no |
Thanks! Now everything works correct. Merging. |
Hi!
This pull request addresses three issues described in #145.
~/.cache/qucs-s
on GNU/Linux)~/QucsWorkspace
I've tested all three changes, but testing of the first one was incomplete: I've tested only the
ngspice
simulation because I don't have a single clue how to run other types like VHDL, ASCO, etc. (I am complete noob in electrical engineering to be honest)