New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplified clustering logic #340

Merged
merged 1 commit into from Mar 8, 2016

Conversation

Projects
None yet
2 participants
@jklare
Contributor

jklare commented Feb 11, 2016

  • removed check if clustering enabled in cluster recipes since this should not
    be needed
  • streamlined clustering attributes
  • simplified logic in rabbitmq.config template for clustering
  • adapted README
  • fixed some rubocop offenses
simplified clustering logic
* removed check if clustering enabled in cluster recipes since this should not
  be needed
* streamlined clustering attributes
* simplified logic in rabbitmq.config template for clustering
* adapted README
* fixed some rubocop offenses
@jjasghar

This comment has been minimized.

Show comment
Hide comment
@jjasghar

jjasghar Feb 11, 2016

Collaborator

We don't have many good tests around the clustering stuff. Any chance you can write some up to verify that these changes won't break it.

I don't run rabbit in clustering mode, so I'm leaning on the community to create this.

@michaelklishin any thoughts here?

Collaborator

jjasghar commented Feb 11, 2016

We don't have many good tests around the clustering stuff. Any chance you can write some up to verify that these changes won't break it.

I don't run rabbit in clustering mode, so I'm leaning on the community to create this.

@michaelklishin any thoughts here?

jjasghar added a commit that referenced this pull request Mar 8, 2016

@jjasghar jjasghar merged commit 2dc1ba9 into rabbitmq:master Mar 8, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment