Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.11: definition import ignores virtual hosts' default queue type setting #5399

Closed
ikavgo opened this issue Jul 30, 2022 · 4 comments · Fixed by #5408
Closed

3.11: definition import ignores virtual hosts' default queue type setting #5399

ikavgo opened this issue Jul 30, 2022 · 4 comments · Fixed by #5408
Assignees
Milestone

Comments

@ikavgo
Copy link
Contributor

ikavgo commented Jul 30, 2022

This is in follow-up to #5305. As reported by @adamcasey in #5330 (comment):


I do think rabbitmqctl import_definitions isn't picking this setting up

  1. Create vhost-def.json containing {"vhosts":[{"limits":[],"metadata":{"default_queue_type":"quorum","description":"","tags":[]},"name":"manual-dqt-test"}]}
    1. Worth noting export_definitions does give this output
  2. rabbitmqctl import_definitions vhost-def.json
  3. rabbitmqctl ctl list_vhosts name,default_queue_type shows all vhosts as default queue type undefined and client-declared queues default to classic

The export / import behaviour here is a little tricky besides this though - imo the perfect outcome would be all queues were declared on import as though the client had re-sent the queue.declare method. I suspect this would require storing what the x-queue-type declaration property was alongside the default queue type though.

@ikavgo ikavgo self-assigned this Jul 30, 2022
@michaelklishin
Copy link
Member

Boot time imports were not updated either.

All initial work was done on client operations because that's what the user who needs it at massive scale described.

@michaelklishin michaelklishin added this to the 3.11.0 milestone Jul 30, 2022
@michaelklishin michaelklishin changed the title Import definitions doesn't pickup default queue type? 3.11: definition import ignores virtual hosts' default queue type setting Jul 30, 2022
mergify bot pushed a commit that referenced this issue Aug 1, 2022
(cherry picked from commit 0f541f4)

# Conflicts:
#	deps/rabbit/test/definition_import_SUITE.erl
@ikavgo
Copy link
Contributor Author

ikavgo commented Aug 1, 2022

@michaelklishin shall I continue with boot time imports?

@michaelklishin
Copy link
Member

@ikvmw sure

@ikavgo
Copy link
Contributor Author

ikavgo commented Aug 2, 2022

It looks like boot time imports work now too.

michaelklishin added a commit that referenced this issue Aug 2, 2022
rabbitmqctl(8): add new virtual host information items (follow-up to #5399)
mergify bot pushed a commit that referenced this issue Aug 2, 2022
michaelklishin added a commit that referenced this issue Aug 2, 2022
rabbitmqctl(8): add new virtual host information items (follow-up to #5399) (backport #5418)
mergify bot pushed a commit that referenced this issue Aug 2, 2022
(cherry picked from commit 6aff83c)
(cherry picked from commit 8b6e5f4)
michaelklishin added a commit that referenced this issue Aug 2, 2022
rabbitmqctl(8): add new virtual host information items (follow-up to #5399) (backport #5418) (backport #5424)
@michaelklishin michaelklishin modified the milestones: 3.11.0, 3.10.8 Aug 2, 2022
mergify bot pushed a commit that referenced this issue Aug 2, 2022
(cherry picked from commit 0f541f4)

# Conflicts:
#	deps/rabbit/test/definition_import_SUITE.erl
(cherry picked from commit ff4c1df)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants