Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement fallback secret for credentials obfuscation (by @luos) #4841

Merged
merged 2 commits into from May 19, 2022

Conversation

michaelklishin
Copy link
Member

@michaelklishin michaelklishin commented May 18, 2022

This PR is submitted on behalf of @luos.

Proposed Changes

This introduces support for credentials_obfuscation's fallback secret. This mechanism
was added for secret rotation and upgrades.

This also moves the moment when the primary secret is set to earlier in the boot process.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Author:    Lajos Gerecs <lajos.gerecs@erlang-solutions.com>
@michaelklishin michaelklishin merged commit c22e1cb into master May 19, 2022
@michaelklishin michaelklishin deleted the luos-add-co-fallback branch May 19, 2022 11:28
@michaelklishin michaelklishin added this to the 3.10.2 milestone May 19, 2022
michaelklishin added a commit that referenced this pull request May 19, 2022
Implement fallback secret for credentials obfuscation (by @luos) (backport #4841)
michaelklishin added a commit that referenced this pull request May 19, 2022
Implement fallback secret for credentials obfuscation (by @luos) (backport #4841) (backport #4847)
michaelklishin added a commit that referenced this pull request May 19, 2022
Implement fallback secret for credentials obfuscation (by @luos) (backport #4841) (backport #4847) (backport #4850)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants