Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify BUILD files by using new macros from rules_erlang 3.9.0 #6928

Merged
merged 3 commits into from Jan 19, 2023
Merged

Simplify BUILD files by using new macros from rules_erlang 3.9.0 #6928

merged 3 commits into from Jan 19, 2023

Conversation

pjk25
Copy link
Contributor

@pjk25 pjk25 commented Jan 18, 2023

This is also a necessary transformation prior to using gazelle

@pjk25 pjk25 mentioned this pull request Jan 18, 2023
Merged
12 tasks
@mergify mergify bot added the bazel label Jan 18, 2023
@pjk25 pjk25 marked this pull request as ready for review January 18, 2023 20:59
michaelklishin
michaelklishin approved these changes Jan 19, 2023
View reviewed changes
Copy link
Member

@michaelklishin michaelklishin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected for me locally.

@pjk25 pjk25 merged commit 1a9f3f4 into main Jan 19, 2023
@pjk25 pjk25 deleted the rin/use-new-rules_erlang-macros branch January 19, 2023 09:03
@mergify mergify bot mentioned this pull request Jan 19, 2023
Merged
pjk25 added a commit that referenced this pull request Jan 19, 2023
@mergify @pjk25
Simplify BUILD files by using new macros from rules_erlang 3.9.0 (bac…
7671052 
…kport #6928) (#6934)

* Use improved assert_suites2 macro from rules_erlang 3.9.0

(cherry picked from commit a317b30)

# Conflicts:
#	deps/rabbit/BUILD.bazel

* Invoke assert_suites macro in all deps/*

including those that don't currently have tests, in case tests are
added

(cherry picked from commit 5bb6090)

* Avoid the need to pass package name to rabbitmq_integration_suite

(cherry picked from commit 5ef8923)

# Conflicts:
#	deps/rabbit/BUILD.bazel

* Fixup backport

Co-authored-by: Rin Kuryloski <kuryloskip@vmware.com>
mergify bot added a commit that referenced this pull request Jan 19, 2023
@mergify
Simplify BUILD files by using new macros from rules_erlang 3.9.0 (bac…
60ed67b 
…kport #6928) (#6934)

* Use improved assert_suites2 macro from rules_erlang 3.9.0

(cherry picked from commit a317b30)

# Conflicts:
#	deps/rabbit/BUILD.bazel

* Invoke assert_suites macro in all deps/*

including those that don't currently have tests, in case tests are
added

(cherry picked from commit 5bb6090)

* Avoid the need to pass package name to rabbitmq_integration_suite

(cherry picked from commit 5ef8923)

# Conflicts:
#	deps/rabbit/BUILD.bazel

* Fixup backport

Co-authored-by: Rin Kuryloski <kuryloskip@vmware.com>
(cherry picked from commit 7671052)

# Conflicts:
#	deps/rabbit/BUILD.bazel
#	deps/rabbitmq_amqp1_0/BUILD.bazel
#	deps/rabbitmq_federation/BUILD.bazel
#	deps/rabbitmq_management/BUILD.bazel
#	deps/rabbitmq_shovel_management/BUILD.bazel
pjk25 added a commit that referenced this pull request Jan 19, 2023
@mergify @pjk25
Simplify BUILD files by using new macros from rules_erlang 3.9.0 (bac…
9e3f7d5 
…kport #6928) (backport #6934) (#6936)

* Simplify BUILD files by using new macros from rules_erlang 3.9.0 (backport #6928) (#6934)

* Use improved assert_suites2 macro from rules_erlang 3.9.0

(cherry picked from commit a317b30)

# Conflicts:
#	deps/rabbit/BUILD.bazel

* Invoke assert_suites macro in all deps/*

including those that don't currently have tests, in case tests are
added

(cherry picked from commit 5bb6090)

* Avoid the need to pass package name to rabbitmq_integration_suite

(cherry picked from commit 5ef8923)

# Conflicts:
#	deps/rabbit/BUILD.bazel

* Fixup backport

Co-authored-by: Rin Kuryloski <kuryloskip@vmware.com>
(cherry picked from commit 7671052)

# Conflicts:
#	deps/rabbit/BUILD.bazel
#	deps/rabbitmq_amqp1_0/BUILD.bazel
#	deps/rabbitmq_federation/BUILD.bazel
#	deps/rabbitmq_management/BUILD.bazel
#	deps/rabbitmq_shovel_management/BUILD.bazel

* Fixup backport

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Rin Kuryloski <kuryloskip@vmware.com>
mergify bot added a commit that referenced this pull request Jan 19, 2023
@mergify
Simplify BUILD files by using new macros from rules_erlang 3.9.0 (bac…
680d248 
…kport #6928) (backport #6934) (#6936)

* Simplify BUILD files by using new macros from rules_erlang 3.9.0 (backport #6928) (#6934)

* Use improved assert_suites2 macro from rules_erlang 3.9.0

(cherry picked from commit a317b30)

# Conflicts:
#	deps/rabbit/BUILD.bazel

* Invoke assert_suites macro in all deps/*

including those that don't currently have tests, in case tests are
added

(cherry picked from commit 5bb6090)

* Avoid the need to pass package name to rabbitmq_integration_suite

(cherry picked from commit 5ef8923)

# Conflicts:
#	deps/rabbit/BUILD.bazel

* Fixup backport

Co-authored-by: Rin Kuryloski <kuryloskip@vmware.com>
(cherry picked from commit 7671052)

# Conflicts:
#	deps/rabbit/BUILD.bazel
#	deps/rabbitmq_amqp1_0/BUILD.bazel
#	deps/rabbitmq_federation/BUILD.bazel
#	deps/rabbitmq_management/BUILD.bazel
#	deps/rabbitmq_shovel_management/BUILD.bazel

* Fixup backport

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Rin Kuryloski <kuryloskip@vmware.com>
(cherry picked from commit 9e3f7d5)

# Conflicts:
#	deps/rabbit/BUILD.bazel
#	deps/rabbitmq_amqp1_0/BUILD.bazel
#	deps/rabbitmq_auth_backend_oauth2/BUILD.bazel
#	deps/rabbitmq_federation/BUILD.bazel
#	deps/rabbitmq_management_agent/BUILD.bazel
#	deps/rabbitmq_peer_discovery_consul/BUILD.bazel
#	deps/rabbitmq_shovel/BUILD.bazel
#	deps/rabbitmq_shovel_management/BUILD.bazel
#	deps/rabbitmq_stomp/BUILD.bazel
#	deps/rabbitmq_stream/BUILD.bazel
#	deps/rabbitmq_web_dispatch/BUILD.bazel
pjk25 added a commit that referenced this pull request Jan 19, 2023
@mergify @pjk25
Simplify BUILD files by using new macros from rules_erlang 3.9.0 (bac…
35ab7a4 
…kport #6928) (backport #6934) (backport #6936) (#6949)

* Simplify BUILD files by using new macros from rules_erlang 3.9.0 (backport #6928) (backport #6934) (#6936)

* Simplify BUILD files by using new macros from rules_erlang 3.9.0 (backport #6928) (#6934)

* Use improved assert_suites2 macro from rules_erlang 3.9.0

(cherry picked from commit a317b30)

# Conflicts:
#	deps/rabbit/BUILD.bazel

* Invoke assert_suites macro in all deps/*

including those that don't currently have tests, in case tests are
added

(cherry picked from commit 5bb6090)

* Avoid the need to pass package name to rabbitmq_integration_suite

(cherry picked from commit 5ef8923)

# Conflicts:
#	deps/rabbit/BUILD.bazel

* Fixup backport

Co-authored-by: Rin Kuryloski <kuryloskip@vmware.com>
(cherry picked from commit 7671052)

# Conflicts:
#	deps/rabbit/BUILD.bazel
#	deps/rabbitmq_amqp1_0/BUILD.bazel
#	deps/rabbitmq_federation/BUILD.bazel
#	deps/rabbitmq_management/BUILD.bazel
#	deps/rabbitmq_shovel_management/BUILD.bazel

* Fixup backport

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Rin Kuryloski <kuryloskip@vmware.com>
(cherry picked from commit 9e3f7d5)

# Conflicts:
#	deps/rabbit/BUILD.bazel
#	deps/rabbitmq_amqp1_0/BUILD.bazel
#	deps/rabbitmq_auth_backend_oauth2/BUILD.bazel
#	deps/rabbitmq_federation/BUILD.bazel
#	deps/rabbitmq_management_agent/BUILD.bazel
#	deps/rabbitmq_peer_discovery_consul/BUILD.bazel
#	deps/rabbitmq_shovel/BUILD.bazel
#	deps/rabbitmq_shovel_management/BUILD.bazel
#	deps/rabbitmq_stomp/BUILD.bazel
#	deps/rabbitmq_stream/BUILD.bazel
#	deps/rabbitmq_web_dispatch/BUILD.bazel

* Fixup backport

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Rin Kuryloski <kuryloskip@vmware.com>
@binarin binarin mentioned this pull request Jan 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelklishin michaelklishin michaelklishin approved these changes

Assignees
No one assigned
Labels
backport-v3.11.x bazel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pjk25 @michaelklishin